Merged
Conversation
Meant to filter archived, not done
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes agent session pickers/quick access so they exclude archived sessions (rather than excluding completed sessions), and ensures agent-host–provided session list items correctly surface the archived state.
Changes:
- Introduce and reuse a shared
shouldShowSessionInPickerpredicate to hide archived sessions while still honoring the configured session filter. - Update agent sessions quick access and picker filtering to include completed sessions and exclude archived sessions.
- Mark agent-host session list items as
archivedbased on theSessionStatus.IsArchivedflag, with added test coverage.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionsDataSource.test.ts | Adds unit coverage for picker filtering behavior (completed included, archived excluded). |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatContribution.test.ts | Adds coverage ensuring agent-host refresh marks items as archived when appropriate. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsQuickAccess.ts | Applies the shared picker predicate so quick access hides archived sessions consistently. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsPicker.ts | Implements shouldShowSessionInPicker and updates picker filtering accordingly. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSessionListController.ts | Sets archived on IChatSessionItem based on SessionStatus.IsArchived (and passes computed status). |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 0
anthonykim1
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meant to filter archived, not done