Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates sanity UI tests to reliably dismiss the current welcome/onboarding dialog so the sanity test flow can proceed.
Changes:
- Switch
dismissWelcomeDialogfrom clicking a “Skip” button to clicking the onboarding close button. - Adjust visibility/hidden waits to match the new close button locator.
Show a summary per file
| File | Description |
|---|---|
| test/sanity/src/uiTest.ts | Updates the welcome dialog dismissal logic to target the new onboarding close button. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
lszomoru
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix sanity tests.