Rework titlebar item to use View > Browser command#312440
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reworks the Integrated Browser titlebar entry so it uses the same command as the View > Browser menu item, centralizing the “open vs list tabs” behavior behind a single command ID.
Changes:
- Introduces
workbench.action.browser.openOrListand routes both the View menu and titlebar button through it. - Removes the previous separate titlebar menu contributions for “Open Integrated Browser” vs “Quick Open Browser Tab…”.
- Updates the quick pick placeholder to no longer suggest URL entry.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/features/browserTabManagementFeatures.ts | Adds the new Open-or-List action, wires it into titlebar + View menu, and removes the prior titlebar-only entries. |
| src/vs/platform/browserView/common/browserView.ts | Adds the new BrowserViewCommandId.OpenOrList command ID. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
+406
to
+411
| class OpenOrListBrowsersAction extends Action2 { | ||
| constructor() { | ||
| super({ | ||
| id: OpenBrowserFromViewMenuAction.ID, | ||
| title: localize2('browser.openFromViewMenuAction', "Browser"), | ||
| id: BrowserViewCommandId.OpenOrList, | ||
| title: localize2('browser.openOrListAction', "Browser"), | ||
| icon: Codicon.globe, |
There was a problem hiding this comment.
OpenOrListBrowsersAction is named in the plural, but the command/title is singular ("Browser") and the action is effectively "open browser" or "list tabs". Consider renaming the class (and any related identifiers) to a singular form to better match behavior and reduce confusion when searching for the action.
pwang347
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.