Fix quoted ID parsing in check-requirements-linux.sh#312466
Open
XQZZZ13 wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix quoted ID parsing in check-requirements-linux.sh#312466XQZZZ13 wants to merge 2 commits intomicrosoft:mainfrom
XQZZZ13 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Source /etc/os-release instead of extracting ID via grep+sed. The previous regex `ID=([^"]+)` fails on distributions where the ID value is double-quoted (e.g. `ID="rocky"` on Rocky Linux 8.5, RHEL, CentOS, openSUSE), because the `[^"]` character class cannot match any character after `ID=`. Sourcing the file is the intended use per os-release(5) and correctly handles both quoted and unquoted values. The subshell created by the surrounding `$(...)` prevents the sourced variables from leaking into the script's environment. Fixes microsoft#232159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source /etc/os-release instead of extracting ID via grep+sed. The previous regex
ID=([^"]+)fails on distributions where the ID value is double-quoted (e.g.ID="rocky"on Rocky Linux 8.5, RHEL, CentOS, openSUSE), because the[^"]character class cannot match any character afterID=.Sourcing the file is the intended use per os-release(5) and correctly handles both quoted and unquoted values. The subshell created by the surrounding
$(...)prevents the sourced variables from leaking into the script's environment.Fixes #232159