mobile: adjust context menu and toolbar positions/sizes.#312475
Merged
mobile: adjust context menu and toolbar positions/sizes.#312475
Conversation
The previous mobile quick pick override forced the widget into a full-width bottom sheet. That worked for standalone command-palette style flows but broke pickers triggered from the chat input toolbar (e.g. Configure Tools), which felt jarringly modal and detached from the trigger. Drop the position override and just expand the width to use the viewport with 8px safe-area gutters. The picker stays anchored to its trigger but no longer truncates titles, descriptions or the filter input. Touch targets in the list bumped to 44px. Also remove the matching mobile context menu bottom-sheet rule which caused the same disconnected-from-trigger feel.
The phone-layout touch-target rule applied min-width/min-height 44px to every `.action-item > .action-label` to hit Apple's touch target minimum. In the chat input toolbar (Local / Auto / agent / model / tools / send) that stretched buttons to 50px tall while adjacent dropdown labels stayed at 22px, producing a huge hover background and an unbalanced row. Add `.chat-input-toolbars` to the exclusion list alongside the quick pick widget. Items now render at their natural ~22px size matching the input bar. Verified in iPhone 14 Pro emulation: hover on "Auto" now shows a tight 52x22 background instead of 52x50.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts phone-layout CSS in the Agents/Sessions workbench to better balance touch target sizing and mobile picker/menu presentation.
Changes:
- Excludes
.chat-input-toolbars(and quick pick toolbars) from the global 44px minimum touch-target sizing rule. - Updates phone-layout quick pick sizing/width behavior (viewport-gutter style instead of fixed bottom-sheet rules).
- Removes the phone-layout “Mobile Context Menus” bottom action-sheet CSS rules.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/browser/media/style.css | Tweaks phone-layout touch sizing exceptions and revises quick pick / context menu mobile layout CSS. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
dmitrivMS
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phone-layout touch-target rule applied min-width/min-height 44px to every
.action-item > .action-labelto hit Apple's touch target minimum. In the chat input toolbar (Local / Auto / agent / model / tools / send) that stretched buttons to 50px tall while adjacent dropdown labels stayed at 22px, producing a huge hover background and an unbalanced row.Add
.chat-input-toolbarsto the exclusion list alongside the quick pick widget. Items now render at their natural ~22px size matching the input bar.Verified in iPhone 14 Pro emulation: hover on "Auto" now shows a tight 52x22 background instead of 52x50.