round trip permission levels to extension#312479
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that permission/option changes (notably permission levels) made during an active turn are propagated through session options so extensions/providers can honor them immediately.
Changes:
- Round-trip
permissionLevelupdates viaIChatSessionsService.setSessionOptionfrom the chat input and sessions UI pickers. - Teach Copilot CLI sessions to (a) initialize permission level from initial session options and (b) apply live
permissionLevelupdates to active SDK sessions. - Add Claude session provider handling for live
permissionModeoption updates, with accompanying tests.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Pushes permission level changes into session options for the active chat session. |
| src/vs/sessions/contrib/copilotChatSessions/browser/permissionPicker.ts | Sends permission level selection via session options (for extension/provider visibility). |
| src/vs/sessions/contrib/copilotChatSessions/browser/claudePermissionModePicker.ts | Sends Claude permission mode selection via session options (for extension/provider visibility). |
| extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts | Plumbs permission level from initial options and applies live option updates to active CLI sessions. |
| extensions/copilot/src/extension/chatSessions/vscode-node/claudeChatSessionContentProvider.ts | Handles live permission mode option changes by updating Claude session state. |
| extensions/copilot/src/extension/chatSessions/vscode-node/test/*.spec.ts | Adds/updates unit tests covering initial and live option propagation behavior. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 3
eleanorjboyd
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changing permission levels mid turn should now be honored.
CLI autopilot and claude plan mode maybe need some testing to figure out what the right thing to do