Fix enter/exit plan mode not reflecting in UI#312487
Merged
TylerLeonhardt merged 2 commits intomainfrom Apr 25, 2026
Merged
Conversation
The pipeline wasn't hooked up properly for certain input states.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a UI sync issue where EnterPlanMode/ExitPlanMode-driven permission-mode changes were not reflected when VS Code rebuilt the chat input state from previousInputState.
Changes:
- Refactors
getChatSessionInputStateto always wire the “external permission mode” reactive subscription (both fresh andpreviousInputStaterestoration paths). - Adds a regression test covering
previousInputStaterestoration + external permission updates. - Documents the input-state reactive pipeline architecture and invariants.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/vscode-node/claudeChatSessionContentProvider.ts | Ensures external permission mode changes update the input UI even when the state is rebuilt from previousInputState. |
| extensions/copilot/src/extension/chatSessions/vscode-node/test/claudeChatSessionContentProvider.spec.ts | Adds coverage for the restored-pipeline scenario to prevent regression. |
| extensions/copilot/src/extension/chatSessions/claude/AGENTS.md | Adds developer documentation explaining the reactive pipeline and the critical subscription placement invariant. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
justschen
previously approved these changes
Apr 25, 2026
justschen
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pipeline wasn't hooked up properly for certain input states.