Don't add listener for webview webview resource load#312490
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Apr 25, 2026
Merged
Don't add listener for webview webview resource load#312490mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
TylerLeonhardt
approved these changes
Apr 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the listener leak warning reported for WebviewElement resource loading by avoiding per-resource cancellation listeners and ensuring active transferable streams are properly closed on disposal.
Changes:
- Track active
ReadableStreamcontrollers during resource streaming to avoid registering manytoken.onCancellationRequestedlisteners. - Close and clear all active stream controllers when the webview element is disposed.
- Add early
_disposedguards inloadResourceto avoid doing work/sending responses after disposal.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/webview/browser/webviewElement.ts | Removes per-stream cancellation listener pattern and adds centralized stream controller cleanup on webview disposal to prevent listener leak warnings. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312367