More effective disabling of browser tools in agents app#312535
Merged
More effective disabling of browser tools in agents app#312535
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make browser chat tools disable more reliably in the Agents (sessions) window by switching gating from a config-change listener to context-key based rules, and by explicitly excluding sessions windows from “share with agent” eligibility.
Changes:
- Replace configuration-based enablement checks for browser chat tools with
IContextKeyService+contextMatchesRules(...)logic. - Export and reuse a shared context expression (
canShareBrowserWithAgentContext) to control both tool registration and sharing UI. - Add
IsSessionsWindowContext.negate()to prevent browser sharing/tools in sessions windows.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/browserView/electron-browser/tools/browserTools.contribution.ts |
Switches tool registration updates from config events to context-key changes; gates registration via canShareBrowserWithAgentContext. |
src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorChatFeatures.ts |
Exports canShareBrowserWithAgentContext and updates it to exclude sessions windows. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
roblourens
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.