refactor: update session management to use onDidDispose for cleanup and lock folder group for existing sessions#312562
Merged
TylerLeonhardt merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
…nd lock folder group for existing sessions Simplifying the options logic sets us up for success to add worktree support.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Claude chat session input-state lifecycle management to use ChatSessionInputState.onDidDispose for deterministic cleanup, and adjusts “folder” option locking behavior to be driven by sessionResource (locking for existing/started sessions).
Changes:
- Replaced
WeakRef/FinalizationRegistry-based cleanup withstate.onDidDispose-driven disposal of per-input-state reactive pipelines. - Updated session-start/locking logic so the folder option group locks when
getChatSessionInputStateis called with asessionResource. - Updated unit test coverage and internal documentation (
AGENTS.md) to match the new lifecycle + locking behavior.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/vscode-node/claudeChatSessionContentProvider.ts | Removes GC-based cleanup + markSessionStarted; disposes per-state autoruns via onDidDispose and locks folder group based on sessionResource. |
| extensions/copilot/src/extension/chatSessions/vscode-node/test/claudeChatSessionContentProvider.spec.ts | Updates expectations to validate folder-locking behavior for existing sessions via sessionResource. |
| extensions/copilot/src/extension/chatSessions/claude/AGENTS.md | Updates design notes to document onDidDispose lifetime management and revised session-start signal behavior. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
roblourens
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifying the options logic sets us up for success to add worktree support.