Restore empty link text for non-skill agent-host links#312571
Merged
roblourens merged 2 commits intomainfrom Apr 26, 2026
Merged
Restore empty link text for non-skill agent-host links#312571roblourens merged 2 commits intomainfrom
roblourens merged 2 commits intomainfrom
Conversation
PR #312557 changed all agent-host link rewriting to preserve the original markdown label, which made every read-tool link render as a plain blue markdown link instead of the rich inline anchor / file widget. Only skill links need a non-empty label (so the skill pill can show the skill name); restore the empty-label behavior for everything else. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the empty-label markdown link rewriting behavior for most vscode-agent-host:// links so the chat renderer’s inline anchor/file widget can take over again, while still preserving non-empty labels for skill (SKILL.md) links.
Changes:
- Update
rewriteLinkTokenRawto emit[](newHref)for non-skill agent-host links and preserve link text only for skill links. - Keep skill-link tagging behavior (
vscodeLinkType=skill) while centralizing the skill check viaisSkill. - Update
stateToProgressAdapterunit tests to expect empty-label rewritten agent-host links.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/stateToProgressAdapter.ts | Adjust link rewriting to collapse most agent-host link labels to empty while preserving skill link labels. |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/stateToProgressAdapter.test.ts | Update expectations for rewritten markdown links to use empty labels. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bpasero
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#312557 changed agent-host link rewriting to preserve the original markdown label for all links, which made every read-tool link render as a plain blue markdown link instead of the rich inline anchor / file widget.
Only skill links (URIs whose basename is
SKILL.md) need a non-empty label, so the skill pill can display the skill name instead of the always-identicalSKILL.mdbasename. Restore the empty-label behavior for everything else so the chat renderer's inline anchor widget takes over again.(Written by Copilot)