fix: avoid forced reflows in DiffEditor gutter during scrolling#312599
Open
g122622 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: avoid forced reflows in DiffEditor gutter during scrolling#312599g122622 wants to merge 1 commit intomicrosoft:mainfrom
g122622 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Use ResizeObserver to asynchronously track button height changes instead of synchronously reading clientHeight during scroll-triggered layout() calls. This eliminates forced style recalculations that caused significant scrolling performance degradation in the Diff Editor. The issue was particularly noticeable after extended use when context keys change frequently, triggering menu updates that exacerbated the forced reflow problem. Fixes microsoft#312596
Contributor
Author
@microsoft-github-policy-service agree |
Contributor
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ResizeObserver to asynchronously track button height changes instead of synchronously reading clientHeight during scroll-triggered layout() calls. This eliminates forced style recalculations that caused significant scrolling performance degradation in the Diff Editor.
The issue was particularly noticeable after extended use when context keys change frequently, triggering menu updates that exacerbated the forced reflow problem.
Fixes #312596
before:
after my fix: