Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a small type-alignment cleanup around Copilot SDK session hooks and tool types in the agent host implementation and its tests, so local code tracks the SDK’s canonical shapes instead of maintaining hand-rolled duplicates.
Changes:
- Replace locally-defined hook/input shapes with types derived from
@github/copilot-sdk(Parameters<>,ReturnType<>,Awaited<>). - Update hook invocations in tests to match the SDK hook input shape (e.g. adding
timestamp,cwd, andtoolResultwhere required). - Tighten tool handler typing in tests by using
Tool/Pick<Tool, ...>instead of ad-hoc structural types.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts | Updates test hook payloads and tool typing to match the SDK’s current hook/tool contracts. |
| src/vs/platform/agentHost/node/copilot/copilotPluginConverters.ts | Derives hook input types directly from SessionConfig['hooks'] and applies them to generated SDK hook handlers. |
| src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts | Removes local duplicated SDK request/response interfaces and derives user-input + tool-hook input types from the SDK config types. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
lszomoru
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.