agents: enhance welcome screen for first-launch and signed-in users#312627
Merged
agents: enhance welcome screen for first-launch and signed-in users#312627
Conversation
- Show a personalized welcome greeting with 'Get Started' button for first-launch users who are already signed in - Show enhanced sign-in screen with welcome content for first-launch users who are not yet signed in - Show plain sign-in screen for returning users who are not signed in - Add 'Happy Agentic Coding!' tagline to all welcome screens - Update 'Sign in with GitHub' button label - Add `isFirstLaunch` parameter to `SessionsWalkthroughOverlay` - Guard autorun auto-dismiss with `isShowingWelcome` to prevent race condition where overlay is dismissed before welcome renders - Fix developer reset command to simulate first-launch experience Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Agents window welcome/onboarding overlay so it can present different first-run experiences depending on whether the user is already signed in and whether it’s the user’s first launch, while also tightening the overlay lifecycle to avoid premature auto-dismissal.
Changes:
- Added a first-launch + already-signed-in “Welcome” greeting state with a “Get Started” action and an
isShowingWelcomeguard to prevent autorun from auto-dismissing the overlay. - Threaded a new
isFirstLaunchparameter throughSessionsWalkthroughOverlaycreation (including the developer reset command path). - Updated styling for the new welcome action/tagline and adjusted tests to pass the new constructor parameter.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/welcome/browser/sessionsWalkthrough.ts | Adds isFirstLaunch, welcome-greeting rendering, isShowingWelcome guard, and updates sign-in copy. |
| src/vs/sessions/contrib/welcome/browser/welcome.contribution.ts | Passes isFirstLaunch, updates autorun guard to respect the welcome-greeting state, and fixes reset behavior. |
| src/vs/sessions/contrib/welcome/browser/media/sessionsWalkthrough.css | Adds styles for the new “Get Started” button and tagline. |
| src/vs/sessions/contrib/welcome/test/browser/welcome.contribution.test.ts | Updates overlay instantiation to include the new isFirstLaunch parameter. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Gate subtitle/tagline behind _isFirstLaunch: returning users see only 'Sign in to continue.' with no tagline; first-launch users see the AI subtitle and 'Happy Agentic Coding!' tagline - Use a single subtitleEl for both paths so _fadeToProgress can update it correctly without stale extra paragraphs - Add unit test for first-launch + already-signed-in welcome screen: verifies isShowingWelcome guard, Get Started button presence, absence of sign-in buttons, and completion on click Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the Agents App welcome screen to provide a tailored experience based on whether the user is signed in and whether it's their first launch.
Changes
Three distinct welcome experiences:
Other improvements:
isFirstLaunchparameter toSessionsWalkthroughOverlayisShowingWelcomeis now set synchronously in the constructor so the autorun guard doesn't auto-dismiss the overlay before the welcome rendersworkbench.action.resetSessionsWelcome) to properly simulate a first-launch experienceFiles changed
sessionsWalkthrough.ts— core overlay; added_isFirstLaunchparam,isShowingWelcomegetter,_renderWelcome()methodwelcome.contribution.ts— overlay lifecycle; addedisFirstLaunchpassing, autorun guard, reset command fixsessionsWalkthrough.css— welcome action/button/tagline styleswelcome.contribution.test.ts— updated tests to passisFirstLaunch = true