Skip to content

[cherry-pick] Revert "Share secrets between Code and Agents app via macOS Keychain"#312735

Merged
deepak1556 merged 1 commit intomainfrom
cherry-pick/312727
Apr 27, 2026
Merged

[cherry-pick] Revert "Share secrets between Code and Agents app via macOS Keychain"#312735
deepak1556 merged 1 commit intomainfrom
cherry-pick/312727

Conversation

@vs-code-engineering
Copy link
Copy Markdown
Contributor

Cherry-pick of #312727 from release/1.118.

Reverts b4347c5

Fixes #312720

@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Apr 27, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor Author

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/darwin/app-entitlements.plist
  • build/azure-pipelines/darwin/steps/product-build-darwin-compile.yml

@deepak1556

Matched files:

  • src/vs/code/electron-main/app.ts

@TylerLeonhardt

Matched files:

  • src/vs/platform/secrets/common/secrets.ts
  • src/vs/platform/secrets/common/sharedKeychainService.ts
  • src/vs/platform/secrets/electron-main/macOSCrossAppSecretSharing.ts
  • src/vs/platform/secrets/electron-main/sharedKeychainMainService.ts

@deepak1556 deepak1556 closed this Apr 27, 2026
@deepak1556 deepak1556 deleted the cherry-pick/312727 branch April 27, 2026 11:35
@deepak1556 deepak1556 restored the cherry-pick/312727 branch April 27, 2026 13:23
@deepak1556 deepak1556 reopened this Apr 27, 2026
@deepak1556 deepak1556 added this to the 1.119.0 milestone Apr 27, 2026
@deepak1556 deepak1556 enabled auto-merge (squash) April 27, 2026 13:24
@deepak1556 deepak1556 merged commit dd05fac into main Apr 27, 2026
49 checks passed
@deepak1556 deepak1556 deleted the cherry-pick/312727 branch April 27, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[macOS 26.3.1] VS Code Insiders 1.118.0 crashes on startup — network process crash loop (exitCode: 9)

1 participant