Agents welcome: improve sign-in flow, loading state, and sign-out reset#312750
Merged
Conversation
lszomoru
previously approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agents welcome overlay rendering logic in the Sessions walkthrough to improve how the disclaimer is displayed and how focus is managed for keyboard users.
Changes:
- Toggle the disclaimer visibility based on whether disclaimer links exist (instead of always hiding it in the welcome step).
- Include disclaimer links in the overlay’s focus trap sequence on the welcome screen.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/welcome/browser/sessionsWalkthrough.ts | Adjusts welcome-step disclaimer visibility and adds disclaimer links to the focusable elements list. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Show loading animation (Agents app logo pulse) on first launch while
default account resolves, avoiding flash of sign-in buttons for
signed-in users
- Add isShowingSignIn flag to prevent premature overlay dismissal
during the loading phase when account resolves externally
- Returning signed-in users skip the overlay entirely; watchSignInState
runs quietly in the background
- On sign-out, clear WELCOME_COMPLETE_KEY so next reload shows the
loading overlay instead of briefly flashing the workbench
- Welcome screen always shows 'Welcome to {productName}' regardless of
sign-in state — no account name or badge in the message
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sandy081
force-pushed
the
sandy081/agents-welcome-disclaimer
branch
from
384a7bb to
6db9211
Compare
alexdima
previously approved these changes
Apr 27, 2026
- Add isShowingSignIn flag to prevent premature overlay auto-dismiss during the loading phase when account resolves before sign-in screen is shown - Guard showWalkthrough and watchSignInState with _store.isDisposed check to avoid acting on a disposed contribution after async resumes - Guard walkthrough.outcome.then continuation against disposed state - Hide sidebar toggle and secondary sidebar actions when welcome overlay is visible (SessionsWelcomeVisibleContext.toNegated()) - Show 'Happy Agentic Coding!' tagline on sign-in screen (was only shown on the signed-in welcome screen) - Delete welcome.contribution.test.ts (tests were not well written) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Yoyokrazy
approved these changes
Apr 27, 2026
sandy081
added
the
~release-cherry-pick
vs-code-engineering
Bot
added
release-cherry-pick
sandy081
added
~release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the Agents App welcome screen flow with several UX and correctness fixes.
Changes
Welcome screen improvements
Sign-in flow correctness
isShowingSignInflag: Prevents premature overlay dismissal during the loading phase. Previously, if the account resolved externally (e.g. VS Code's account provider) while the loading spinner was still visible, the overlay would auto-dismiss before the user ever saw the sign-in screenwatchSignInState()runs quietly in the backgroundSign-out state reset
WELCOME_COMPLETE_KEYis cleared from storage so the next reload shows the full loading overlay instead of briefly flashing the workbench before the sign-in screen appearsCode cleanup
showSessionsWelcomeAfterSignOutfunction (redundant —watchSignInStatealready handles re-showing the overlay on sign-out)IDefaultAccountServicetype instead ofPick<>Files changed
src/vs/sessions/contrib/welcome/browser/sessionsWalkthrough.ts— overlay rendering, loading state, sign-in/welcome screenssrc/vs/sessions/contrib/welcome/browser/welcome.contribution.ts— orchestration, sign-out resetsrc/vs/sessions/contrib/welcome/browser/media/sessionsWalkthrough.css— loading animation stylessrc/vs/sessions/contrib/accountMenu/browser/account.contribution.ts— removed redundantshowSessionsWelcomeAfterSignOutsrc/vs/sessions/contrib/accountMenu/test/browser/account.contribution.test.ts— updated testssrc/vs/sessions/contrib/welcome/test/browser/welcome.contribution.test.ts— updated tests