Remove logic for hiding chat elicitation window for unsandboxed requests#312843
Merged
Conversation
bhavyaus
approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the special-casing that auto-approved terminal tool invocations could automatically retry outside the sandbox without showing an elicitation, ensuring the “automatic unsandbox retry” prompt is always shown when applicable.
Changes:
- Removed
requiresConfirmationForRetryplumbing fromRunInTerminalToolinvocation data and the_confirmAutomaticUnsandboxRetryfast-path. - Updated automatic sandbox retry tests to assert the elicitation UI is created even for auto-approved scenarios (by creating a
ChatModel/session for the test).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts | Removes the “auto-allow retry” shortcut and always routes through elicitation for unsandbox retry confirmation. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts | Updates tests to validate elicitation creation for auto-approved and confirmation-required cases using a real ChatModel session. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/7561
fixes #312924