Skip to content

sessions: make gradient shell background default#312855

Merged
hawkticehurst merged 1 commit into
mainfrom
agents/default-gradient-background-update
Apr 27, 2026
Merged

sessions: make gradient shell background default#312855
hawkticehurst merged 1 commit into
mainfrom
agents/default-gradient-background-update

Conversation

@hawkticehurst
Copy link
Copy Markdown
Member

@hawkticehurst hawkticehurst commented Apr 27, 2026

Summary

  • make the sessions shell gradient background the default treatment
  • remove the sessions.experimental.shellGradientBackground setting and its workbench/configuration plumbing
  • rename the sessions workbench CSS hook to shell-gradient-background and update the layout spec

Minor note: Also using this PR to test this TPI: #312430

Testing

  • npm run compile-check-ts-native
  • npm run valid-layers-check
  • node --experimental-strip-types build/hygiene.ts src/vs/sessions/browser/workbench.ts src/vs/sessions/browser/media/style.css src/vs/sessions/contrib/configuration/browser/configuration.contribution.ts src/vs/sessions/contrib/sessions/browser/media/sessionsViewPane.css src/vs/sessions/LAYOUT.md

Remove the sessions experimental shell gradient toggle and always apply the shell gradient styling for the sessions workbench.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 27, 2026 17:56
@hawkticehurst hawkticehurst added the ~requires-eval-assessment Evals will be run and will generate a report upon completion label Apr 27, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor

⏳ Queued vscode build for 8c59f9f7c079b03e5434480bfa84e382f88d6fd3 (step 1/2).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the Sessions/Agents window’s accent-tinted shell gradient background the default behavior, removing the previous experimental opt-in setting and updating the corresponding CSS hook and layout documentation.

Changes:

  • Always apply the sessions shell gradient background by default (no config toggle).
  • Remove the sessions.experimental.shellGradientBackground setting and its configuration registration/constant.
  • Rename the workbench CSS hook from experimental-shell-gradient-background to shell-gradient-background and update documentation accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/vs/sessions/contrib/sessions/browser/media/sessionsViewPane.css Updates selectors to use the new shell-gradient-background root class for transparent viewpane/sidebar backgrounds.
src/vs/sessions/contrib/configuration/browser/configuration.contribution.ts Removes the configuration registration for the deleted experimental setting.
src/vs/sessions/common/configuration.ts Deletes the now-unused setting ID constant.
src/vs/sessions/browser/workbench.ts Renames the layout class and applies shell-gradient-background unconditionally; removes configuration listener/toggle plumbing.
src/vs/sessions/browser/media/style.css Renames the CSS hook to shell-gradient-background for the root gradient layer and related transparency rules.
src/vs/sessions/LAYOUT.md Updates the layout spec to reflect the new default behavior and documents the change in revision history.

@vs-code-engineering
Copy link
Copy Markdown
Contributor

❌ vscode build did not succeed (result: canceled) — eval-assessment publish was not queued.

@hawkticehurst hawkticehurst added ~requires-eval-assessment Evals will be run and will generate a report upon completion and removed ~requires-eval-assessment Evals will be run and will generate a report upon completion labels Apr 27, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor

⏳ Queued vscode build for 8c59f9f7c079b03e5434480bfa84e382f88d6fd3 (step 1/2).

@hawkticehurst hawkticehurst merged commit 7ad23fe into main Apr 27, 2026
30 checks passed
@hawkticehurst hawkticehurst deleted the agents/default-gradient-background-update branch April 27, 2026 23:37
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~requires-eval-assessment Evals will be run and will generate a report upon completion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants