Skip to content

enable progress border in insiders + reduce motion#312878

Merged
justschen merged 3 commits into
mainfrom
justin/sliggoo
Apr 28, 2026
Merged

enable progress border in insiders + reduce motion#312878
justschen merged 3 commits into
mainfrom
justin/sliggoo

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

turns it on by default, makes sure that reduced motion setting is honored

Copilot AI review requested due to automatic review settings April 27, 2026 19:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the chat input “progress border” by default in non-stable (Insiders) builds and updates the chat UI to honor reduced-motion by suppressing the animated border and falling back to persistent progress details when motion is reduced.

Changes:

  • Default chat.progressBorder.enabled to true for non-stable builds and update the setting description to mention reduced motion.
  • Disable the input “working” border when reduced motion is enabled and react to reduced-motion changes.
  • Treat “progress border enabled + reduced motion” like “progress border disabled” for purposes of showing persistent progress details (list/thinking/progress parts).
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts Hooks reduced-motion changes and suppresses the input progress border when motion is reduced.
src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts Adjusts logic for rendering persistent progress details when border is enabled but motion is reduced.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts Makes thinking content’s “show progress details” honor reduced motion when border is enabled.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatProgressContentPart.ts Makes working-progress label mode honor reduced motion when border is enabled.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Enables the setting by default on Insiders and updates the configuration description.

Copilot's findings

  • Files reviewed: 5/5 changed files
  • Comments generated: 4

Comment thread src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts Outdated
Comment thread src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts
Comment thread src/vs/workbench/contrib/chat/browser/chat.contribution.ts Outdated
@justschen justschen marked this pull request as ready for review April 28, 2026 02:21
@justschen justschen enabled auto-merge (squash) April 28, 2026 02:21
@justschen justschen merged commit 25b6fc9 into main Apr 28, 2026
26 checks passed
@justschen justschen deleted the justin/sliggoo branch April 28, 2026 02:40
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants