fix placeholder not showing up + inline chat progress border#312979
Merged
fix placeholder not showing up + inline chat progress border#312979
Conversation
justschen
added
the
~release-cherry-pick
Contributor
|
This PR will be automatically cherry-picked to |
Contributor
blocks-ci screenshots changedReplace the contents of Updated blocks-ci-screenshots.md<!-- auto-generated by CI — do not edit manually -->
#### editor/codeEditor/CodeEditor/Dark
#### editor/codeEditor/CodeEditor/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes regressions introduced by placeholder truncation work by scoping the container-query-based placeholder styling to non-compact chat inputs, and adjusts progress-border behavior in inline chat contexts.
Changes:
- Scope
container-type: inline-sizeand placeholder truncation CSS to non-compact chat inputs to avoid breaking placeholder rendering in compact contexts. - Update progress-border enabling logic to exclude inline chat widgets.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/media/chat.css | Restricts container-query placeholder truncation styling to non-compact inputs to prevent zero-width placeholder rendering in compact modes. |
| src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts | Changes when the “working/progress border” class is applied, now gating it off for inline chat. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
chrmarti
approved these changes
Apr 28, 2026
aeschli
approved these changes
Apr 28, 2026
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @mrleemurray #312337 breaks the placeholders of inline, terminal, and quickchat.