Skip to content

feat: enhance inline chat functionality with additional services and mock implementations #313017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrieken merged 1 commit into from
Apr 28, 2026
+42 −0
Merged

feat: enhance inline chat functionality with additional services and mock implementations #313017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/vs/workbench/test/browser/componentFixtures/editor/inlineChatZoneWidget.fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import { IDecorationsService } from '../../../../services/decorations/common/dec
import { ITextFileService } from '../../../../services/textfile/common/textfiles.js';
import { IWorkbenchAssignmentService } from '../../../../services/assignment/common/assignmentService.js';
import { IChatEntitlementService } from '../../../../services/chat/common/chatEntitlementService.js';
import { IChatInputNotificationService } from '../../../../contrib/chat/browser/widget/input/chatInputNotificationService.js';
import { IPathService } from '../../../../services/path/common/pathService.js';
import { IChatWidgetService, IChatAccessibilityService } from '../../../../contrib/chat/browser/chat.js';
import { IChatContextPickService } from '../../../../contrib/chat/browser/attachments/chatContextPickService.js';
Expand Down Expand Up @@ -63,6 +64,14 @@ import { IMarkdownRendererService, MarkdownRendererService } from '../../../../.
import { observableValue } from '../../../../../base/common/observable.js';
import { ComponentFixtureContext, createEditorServices, createTextModel, defineComponentFixture, defineThemedFixtureGroup, registerWorkbenchServices } from '../fixtureUtils.js';
import { InlineChatZoneWidget } from '../../../../contrib/inlineChat/browser/inlineChatZoneWidget.js';
import { ChatModel } from '../../../../contrib/chat/common/model/chatModel.js';
import { IChatEditingService } from '../../../../contrib/chat/common/editing/chatEditingService.js';
import { Target } from '../../../../contrib/chat/common/promptSyntax/promptTypes.js';
import { ICustomizationHarnessService } from '../../../../contrib/chat/common/customizationHarnessService.js';

// Side-effect import: registers InputEditorDecorations into ChatWidget.CONTRIBS
// so the placeholder decoration is rendered.
import '../../../../contrib/chat/browser/widget/input/editor/chatInputEditorContrib.js';

// CSS imports
import '../../../../contrib/inlineChat/browser/media/inlineChat.css';
Expand Down Expand Up @@ -203,9 +212,11 @@ function renderInlineChatZoneWidget({ container, disposableStore, theme }: Compo
}());
reg.defineInstance(IChatTipService, new class extends mock<IChatTipService>() {
readonly onDidReceiveTip = Event.None;
override resetSession() { }
}());
reg.defineInstance(IChatDebugService, new class extends mock<IChatDebugService>() {
override readonly onDidAddEvent = Event.None;
override getEvents() { return []; }
}());
reg.defineInstance(IChatEntitlementService, new class extends mock<IChatEntitlementService>() {
override readonly sentimentObs = observableValue('sentiment', { completed: true });
Expand All @@ -222,10 +233,26 @@ function renderInlineChatZoneWidget({ container, disposableStore, theme }: Compo
override readonly onDidChangeSessionOptions = Event.None;
override readonly onDidChangeOptionGroups = Event.None;
override readonly onDidChangeAvailability = Event.None;
override readonly onDidChangeCustomizations = Event.None;
override readonly onDidChangeContentProviderSchemes = Event.None;
override readonly onDidChangeItemsProviders = Event.None;
override readonly onDidChangeSessionItems = Event.None;
override readonly onDidCommitSession = Event.None;
override readonly onDidChangeInProgress = Event.None;
override sessionSupportsFork() { return false; }
override supportsDelegationForSessionType() { return false; }
override getOptionGroupsForSessionType() { return undefined; }
override getCustomAgentTargetForSessionType() { return Target.Undefined; }
override requiresCustomModelsForSessionType() { return false; }
override getChatSessionContribution() { return undefined; }
override getCapabilitiesForSessionType() { return undefined; }
override getSessionOptions() { return undefined; }
override hasCustomizationsProvider() { return false; }
}());
reg.defineInstance(ILanguageModelsService, new class extends mock<ILanguageModelsService>() {
override readonly onDidChangeLanguageModels = Event.None;
override getLanguageModelIds() { return []; }
override getVendors() { return []; }
}());
reg.defineInstance(ILanguageModelToolsService, new class extends mock<ILanguageModelToolsService>() {
override readonly onDidChangeTools = Event.None;
Expand Down Expand Up @@ -263,6 +290,17 @@ function renderInlineChatZoneWidget({ container, disposableStore, theme }: Compo
override getHistory() { return []; }
override readonly onDidChangeHistory = Event.None;
}());
reg.defineInstance(IChatEditingService, new class extends mock<IChatEditingService>() {
override editingSessionsObs = observableValue('editingSessionsObs', []);
}());
reg.defineInstance(IChatInputNotificationService, new class extends mock<IChatInputNotificationService>() {
override readonly onDidChange = Event.None;
override getActiveNotification() { return undefined; }
}());
reg.defineInstance(ICustomizationHarnessService, new class extends mock<ICustomizationHarnessService>() {
override readonly onDidChangeSlashCommands = Event.None;
override readonly onDidChangeCustomAgents = Event.None;
}());
reg.defineInstance(IChatContextPickService, new class extends mock<IChatContextPickService>() { }());
reg.defineInstance(IDecorationsService, new class extends mock<IDecorationsService>() { override readonly onDidChangeDecorations = Event.None; }());
reg.defineInstance(ITextFileService, new class extends mock<ITextFileService>() { override readonly untitled = new class extends mock<ITextFileService['untitled']>() { override readonly onDidChangeLabel = Event.None; }(); }());
Expand Down Expand Up @@ -362,6 +400,10 @@ function renderInlineChatZoneWidget({ container, disposableStore, theme }: Compo

zoneWidget.show(new Position(10, 1));

const dummyModel = instantiationService.createInstance(ChatModel, undefined, { initialLocation: ChatAgentLocation.EditorInline, canUseTools: false });
zoneWidget.widget.chatWidget.setModel(dummyModel);
zoneWidget.widget.chatWidget.setInputPlaceholder('Ask Copilot...');

// Force a relayout after the initial show so that the chat widget's
// contentHeight (which includes the toolbar row rendered below the input)
// is fully measured and the zone widget adjusts its height accordingly.
Expand Down
Loading