Skip to content

agents: bump @github/copilot to 1.0.38#313073

Merged
roblourens merged 3 commits into
mainfrom
roblou/agents/update-github-copilot-dependencies
Apr 28, 2026
Merged

agents: bump @github/copilot to 1.0.38#313073
roblourens merged 3 commits into
mainfrom
roblou/agents/update-github-copilot-dependencies

Conversation

@roblourens
Copy link
Copy Markdown
Member

Bumps @github/copilot from ^1.0.34 to ^1.0.38 in both the root and remote/ package.json (and regenerates the corresponding lockfiles). This tracks the version already pinned in extensions/copilot/package.json, per the standing rule that the agent host's copy of @github/copilot should follow the bundled Copilot extension's pin.

@github/copilot-sdk is unchanged (^0.2.2); the SDK's peerDependency-style "@github/copilot": "^1.0.21" is satisfied by 1.0.38.

Verification

  • npm run compile-check-ts-native clean.
  • npm run compile clean.
  • Real-SDK integration test passes:
    AGENT_HOST_REAL_SDK=1 ./scripts/test-integration.sh \
      --run src/vs/platform/agentHost/test/node/protocol/toolApprovalRealSdk.integrationTest.ts \
      --grep "listModels returns well-shaped"
    
    This is the safety net for SDK-shape drift; it confirms the synthetic auto router model still surfaces correctly through the ICopilotModelInfo wrapper added in the previous bump.

No source changes required — the only @github/copilot reference in src/ is the runtime CLI entry-point path in copilotAgent.ts, which is version-agnostic. All TS imports come from @github/copilot-sdk.

(Written by Copilot)

Tracks the version pinned in extensions/copilot/package.json. Updates
both root and remote/ package.json + lockfiles. Verified by re-running
the real-SDK 'listModels returns well-shaped model entries' integration
test (AGENT_HOST_REAL_SDK=1).

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 28, 2026 18:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the agent host’s @github/copilot dependency with the version already pinned by the bundled Copilot extension by bumping it from ^1.0.34 to ^1.0.38 in both the root and remote/ package manifests, with corresponding lockfile regeneration.

Changes:

  • Bump @github/copilot to ^1.0.38 in package.json and remote/package.json.
  • Regenerate package-lock.json and remote/package-lock.json to reflect @github/copilot@1.0.38 and its optional platform packages.
Show a summary per file
File Description
package.json Updates root dependency on @github/copilot to ^1.0.38.
package-lock.json Updates resolved @github/copilot tarball/version and optional platform package versions to 1.0.38.
remote/package.json Updates remote dependency on @github/copilot to ^1.0.38.
remote/package-lock.json Updates resolved @github/copilot tarball/version and optional platform package versions to 1.0.38.

Copilot's findings

Files not reviewed (1)
  • remote/package-lock.json: Language not supported
  • Files reviewed: 2/4 changed files
  • Comments generated: 0

@roblourens roblourens marked this pull request as ready for review April 28, 2026 19:01
The macOS/Electron CI job was failing because `electron.ts` unconditionally
deletes `.build/electron` and re-downloads Electron on every invocation.

When integration tests run CSS/HTML tests via `node-electron.sh`, they call
`npm run electron` which triggers this re-download. This can fail due to
transient network errors (e.g. 502 Bad Gateway from GitHub), causing the
integration test step to fail even though Electron was already downloaded
successfully in the dedicated "Download Electron and Playwright" CI step.

Fix: add a `.version` marker file inside `.build/electron` that records the
Electron version, MS build ID, and architecture. On the next invocation,
`main()` reads this marker and returns early if it matches the expected
version, skipping the unnecessary delete-and-re-download cycle.

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/8d0b4207-2616-497e-9a4f-bf8a39671934

Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>
dmitrivMS
dmitrivMS previously approved these changes Apr 28, 2026
@roblourens roblourens enabled auto-merge (squash) April 28, 2026 20:02
@roblourens roblourens disabled auto-merge April 28, 2026 20:10
…resent"

This reverts commit e1811ec. That
commit was pushed to this PR by another agent and is unrelated to the
@github/copilot bump that this PR is for.

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@roblourens roblourens merged commit 83cbe74 into main Apr 28, 2026
26 checks passed
@roblourens roblourens deleted the roblou/agents/update-github-copilot-dependencies branch April 28, 2026 21:00
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone Apr 28, 2026
dpearson2699 pushed a commit to dpearson2699/vscode that referenced this pull request Apr 29, 2026
* agents: bump @github/copilot to 1.0.38

Tracks the version pinned in extensions/copilot/package.json. Updates
both root and remote/ package.json + lockfiles. Verified by re-running
the real-SDK 'listModels returns well-shaped model entries' integration
test (AGENT_HOST_REAL_SDK=1).

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: skip electron re-download when correct version already present

The macOS/Electron CI job was failing because `electron.ts` unconditionally
deletes `.build/electron` and re-downloads Electron on every invocation.

When integration tests run CSS/HTML tests via `node-electron.sh`, they call
`npm run electron` which triggers this re-download. This can fail due to
transient network errors (e.g. 502 Bad Gateway from GitHub), causing the
integration test step to fail even though Electron was already downloaded
successfully in the dedicated "Download Electron and Playwright" CI step.

Fix: add a `.version` marker file inside `.build/electron` that records the
Electron version, MS build ID, and architecture. On the next invocation,
`main()` reads this marker and returns early if it matches the expected
version, skipping the unnecessary delete-and-re-download cycle.

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/8d0b4207-2616-497e-9a4f-bf8a39671934

Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>

* Revert "fix: skip electron re-download when correct version already present"

This reverts commit e1811ec. That
commit was pushed to this PR by another agent and is unrelated to the
@github/copilot bump that this PR is for.

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>
hediet added a commit that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants