make v2 default mode for inline chat

[jrieken]

No description provided.

[Copilot]

Pull request overview

This PR makes “inline chat v2” the default/only mode by removing the inlineChat.enableV2 gate and updating related context keys, model-selection logic, and Copilot test infrastructure to match the new default behavior.

Changes:

• Removed the inlineChat.enableV2 setting/config plumbing and updated inline-chat context keys to no longer distinguish “v2”.
• Updated chat model selection/filtering so EditorInline requires tool-calling capability unconditionally (no v2 flag).
• Updated Copilot inline-chat intent routing/tests and refreshed (or removed) simulation outcome fixtures accordingly.

Show a summary per file

File	Description
src/vs/workbench/contrib/inlineChat/common/inlineChat.ts	Removes EnableV2 setting and renames/updates inline chat context keys to reflect v2 as default.
src/vs/workbench/contrib/inlineChat/browser/inlineChatSessionServiceImpl.ts	Renames bound context key from HAS_AGENT2 to HAS_AGENT.
src/vs/workbench/contrib/inlineChat/browser/inlineChatActions.ts	Reworks enablement preconditions to use v2 context + legacy notebook inline context expression.
src/vs/workbench/contrib/chat/browser/widget/input/chatModelSelectionLogic.ts	Removes isInlineChatV2Enabled from model filtering; EditorInline now always requires tool calling.
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts	Drops dependency on inlineChat.enableV2 when filtering/selecting models.
src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts	Removes v1/v2 config gate from EditorInline command-detection path.
src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelSelectionLogic.test.ts	Updates tests for new model-filtering signature/behavior (no v2 flag).
extensions/copilot/src/extension/prompt/node/intentDetector.tsx	Removes old-world inline editor routing that depended on inlineChat.enableV2.
extensions/copilot/src/extension/inlineChat2/node/inlineChatIntent.ts	Removes old-world inline chat handling; always uses tool-calling “new world” flow.
extensions/copilot/package.json	Removes editor-location command definitions previously gated on !config.inlineChat.enableV2.
extensions/copilot/test/simulation/inlineChatSimulator.ts	Removes running the legacy Inline strategy for “inline + intent” helper.
extensions/copilot/test/inline/inlineGenerateCode.stest.ts	Stops registering the legacy Inline variant for these inline tests.
extensions/copilot/test/inline/inlineEditCode.stest.ts	Stops registering the legacy Inline variant (currently left commented out).
extensions/copilot/test/outcome/notebook-generate-runtime-inline.json	Updates recorded request hashes for notebook inline scenarios.
extensions/copilot/test/outcome/notebook-generate-inline.json	Updates recorded request hashes for notebook inline scenarios.
extensions/copilot/test/outcome/notebook-edit-inline.json	Updates recorded request hashes for notebook inline scenarios.
extensions/copilot/test/outcome/explain-inline.json	Updates recorded request hashes for explain inline scenario.
extensions/copilot/test/outcome/intent-inline.json	Updates recorded request hashes (many scenarios now record none).
extensions/copilot/test/outcome/-tests-real-world-inline.json	Updates recorded request hashes for /tests inline scenarios.
extensions/copilot/test/outcome/-tests-inline.json	Updates recorded request hashes for /tests inline scenarios.
extensions/copilot/test/outcome/generate-inline.json	Removes obsolete legacy inline generate outcome fixture.
extensions/copilot/test/outcome/edit-inline.json	Removes obsolete legacy inline edit outcome fixture.
extensions/copilot/test/outcome/fix-tsc-inline.json	Removes obsolete legacy inline fix outcome fixture.
extensions/copilot/test/outcome/fix-eslint-inline.json	Removes obsolete legacy inline fix outcome fixture.
extensions/copilot/test/outcome/fix-ruff-inline.json	Removes obsolete legacy inline fix outcome fixture.
extensions/copilot/test/outcome/fix-roslyn-inline.json	Removes obsolete legacy inline fix outcome fixture.
extensions/copilot/test/outcome/fix-pyright-inline.json	Removes obsolete legacy inline fix outcome fixture.
extensions/copilot/test/outcome/fix-pylint-inline.json	Removes obsolete legacy inline fix outcome fixture.
extensions/copilot/test/outcome/fix-powershell-inline.json	Removes obsolete legacy inline fix outcome fixture.
extensions/copilot/test/outcome/fix-cpp-inline.json	Removes obsolete legacy inline fix outcome fixture.
.vscode/settings.json	Removes repo-level default setting for inlineChat.enableV2.

Copilot's findings

• Files reviewed: 31/32 changed files
• Comments generated: 4