Respond to update state changes to update the menu bar#313435
Merged
Conversation
dmitrivMS
added
the
install-update
bpasero
approved these changes
Apr 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Electron main-process menubar so that update-related menu items reflect the current updater state (e.g., showing “Restart to Update” when an update is ready), addressing the reported mismatch in the Update menu label.
Changes:
- Listen to
IUpdateService.onStateChangeand trigger a menu rebuild to refresh update-related menu items.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/menubar/electron-main/menubar.ts | Rebuilds the application menu when update state changes so the Update menu items stay in sync with the updater state. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #313104