Remove some now redundant webview layout logic#313443
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Apr 30, 2026
Merged
Conversation
The webview css anchor positioning should handle this all automatically now Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes now-redundant layout/scroll-driven re-anchoring logic for overlay-based webviews and notebook overlays, relying on CSS anchor positioning to keep overlays aligned automatically.
Changes:
- Remove
WebviewViewPane.layoutBodyoverride that re-laid out the webview on every view layout. - Remove
WebviewEditor’s dimension tracking and editor-part scroll/group-change listeners used to re-set the webview anchor. - Remove notebook editor scroll listener that re-laid out the overlay container over the shadow element.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/webviewView/browser/webviewViewPane.ts | Stops re-anchoring the webview on every layoutBody call; anchoring is now done during render/activation only. |
| src/vs/workbench/contrib/webviewPanel/browser/webviewEditor.ts | Removes layout- and editor-part-event-driven anchor updates and cached dimensions; anchoring happens when claiming the webview. |
| src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts | Removes scroll-driven overlay re-layout for the notebook overlay container. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
dmitrivMS
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webview css anchor positioning should handle this all automatically now