Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion extensions/copilot/src/platform/endpoint/node/responsesApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,48 @@ interface RawMessagesToResponseAPIOptions {
readonly modeChanged?: boolean;
}


function hasMessageShape(item: unknown): item is { role: string; content: unknown } {
return !!item
&& typeof item === "object"
&& typeof (item as { role?: unknown }).role === "string"
&& "content" in item;
}

function hasEmptyType(item: unknown): boolean {
if (!item || typeof item !== "object") {
return true;
}
const type = (item as { type?: unknown }).type;
return typeof type !== "string" || type.trim().length === 0;
}

function normalizeResponsesInputItem<T extends { type?: unknown }>(
item: T
): T | (T & { type: "message" }) | undefined {
if (!item || typeof item !== "object") {
return undefined;
}
if (!hasEmptyType(item)) {
return item;
}
if (hasMessageShape(item)) {
return {
...item,
type: "message"
};
}
return undefined;
}

function normalizeResponsesInput<T extends { type?: unknown }>(
input: readonly T[]
): Array<T | (T & { type: "message" })> {
return input
.map(normalizeResponsesInputItem)
.filter((item): item is T | (T & { type: "message" }) => !!item);
}

function rawMessagesToResponseAPI(modelId: string, messages: readonly Raw.ChatMessage[], ignoreStatefulMarker: boolean, webSocketStatefulMarker: string | undefined, options: RawMessagesToResponseAPIOptions = {}): { input: OpenAI.Responses.ResponseInputItem[]; previous_response_id?: string } {
const { toolsMap, shouldLoadToolFromToolSearch, modeChanged = false } = options;
const latestCompactionMessageIndex = getLatestCompactionMessageIndex(messages);
Expand Down Expand Up @@ -442,7 +484,8 @@ function rawMessagesToResponseAPI(modelId: string, messages: readonly Raw.ChatMe
}
}

return { input, previous_response_id: previousResponseId };
// Defensive normalization: ensure no empty or missing type fields
return { input: normalizeResponsesInput(input), previous_response_id: previousResponseId };
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,27 @@
import { normalizeResponsesInput } from "../responsesApi";

describe("normalizeResponsesInput (regression)", () => {
it("normalizes empty type to message and drops empty items", () => {
const input = [
{ type: "message", role: "user", content: "hello" },
{ type: "", role: "assistant", content: "hi" },
{ type: "" }
];
const expected = [
{ type: "message", role: "user", content: "hello" },
{ type: "message", role: "assistant", content: "hi" }
];
expect(normalizeResponsesInput(input)).toEqual(expected);
});
it("preserves valid tool and reasoning items", () => {
const input = [
{ type: "tool_search_call", foo: 1 },
{ type: "function_call_output", bar: 2 },
{ type: "reasoning", baz: 3 }
];
expect(normalizeResponsesInput(input)).toEqual(input);
});
});
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down