Skip to content

Prunes stale closed repository entries (#313551) #313554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eamodio wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

Prunes stale closed repository entries (#313551) #313554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions extensions/git/src/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,17 @@ export class Model implements IRepositoryResolver, IBranchProtectionProviderRegi
} catch (err) {
// noop
this.logger.trace(`[Model][openRepository] Opening repository for path='${repoPath}' failed. Error:${err}`);

// Prune stale closed-repository entries:
// if the user explicitly asked to reopen a closed repo and the path no longer exists on disk, drop the entry so it does not stick around forever
if (openIfClosed && this._closedRepositoriesManager.isRepositoryClosed(repoPath)) {
try {
await fs.promises.access(repoPath);
} catch {
this._closedRepositoriesManager.deleteRepository(repoPath);
this.logger.info(`[Model][openRepository] Removed stale closed repository entry: ${repoPath}`);
Comment thread
eamodio marked this conversation as resolved.
}
}
}
}

Expand Down
Loading