Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR scaffolds a “changesets” concept into the Sessions/Agents window model by introducing a new ISessionChangeset type and plumbing a changesets observable through session/chat facades and key providers, with tests updated to satisfy the new interface shape.
Changes:
- Add
ISessionChangesetand newchangesetsobservables toIChatandISession. - Plumb empty/default
changesetsobservables through Copilot chat sessions + agent host providers. - Update multiple Sessions-layer tests to include
changesetsin stubs/fixtures.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/services/sessions/common/session.ts | Introduces ISessionChangeset and adds changesets to IChat/ISession. |
| src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts | Adds changesets to the Copilot sessions facade and adapters; currently scaffolded as empty. |
| src/vs/sessions/contrib/agentHost/browser/baseAgentHostSessionsProvider.ts | Adds a changesets observable to agent-host session/chat models. |
| src/vs/sessions/services/sessions/test/browser/sessionsManagementService.test.ts | Updates session/chat stubs to include changesets. |
| src/vs/sessions/contrib/terminal/test/browser/sessionsTerminalContribution.test.ts | Updates test session fixtures to include changesets. |
| src/vs/sessions/contrib/sessions/test/browser/sessionsListModelService.test.ts | Updates test session factory to include changesets. |
| src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts | Updates test session factory to include changesets. |
| src/vs/sessions/contrib/github/test/browser/githubContribution.test.ts | Updates ISession test implementation to include changesets. |
| src/vs/sessions/contrib/chat/test/browser/sessionsConfigurationService.test.ts | Updates session fixtures to include changesets. |
| src/vs/sessions/contrib/agentHost/test/browser/agentHostSkillButtons.test.ts | Updates active session test fixture to include changesets. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts:914
AgentSessionAdapter.update()updates_changesbut does not update the newly introduced_changesets. Ifchangesetsare ever computed from the agent session, this adapter will stop reflecting updates after construction. Updateupdate()to also set_changesetsfrom_extractChangesets(session)(and consider updating it in the same transaction alongside_changes).
this._changesets = observableValue<readonly ISessionChangeset[]>(this, this._extractChangesets(session));
this.changesets = this._changesets;
this._changes = observableValue<readonly ISessionFileChange[]>(this, this._extractChanges(session));
this.changes = this._changes;
- Files reviewed: 10/10 changed files
- Comments generated: 3
Contributor
sandy081
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.