Skip to content

Agents - scaffold Changesets model#313577

Merged
lszomoru merged 3 commits intomainfrom
lszomoru/agents-changeset
May 4, 2026
Merged

Agents - scaffold Changesets model#313577
lszomoru merged 3 commits intomainfrom
lszomoru/agents-changeset

Conversation

@lszomoru
Copy link
Copy Markdown
Member

No description provided.

@lszomoru lszomoru requested review from Copilot and sandy081 April 30, 2026 19:42
@lszomoru lszomoru self-assigned this Apr 30, 2026
@lszomoru lszomoru enabled auto-merge (squash) April 30, 2026 19:42
@lszomoru lszomoru added this to the 1.120.0 milestone Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR scaffolds a “changesets” concept into the Sessions/Agents window model by introducing a new ISessionChangeset type and plumbing a changesets observable through session/chat facades and key providers, with tests updated to satisfy the new interface shape.

Changes:

  • Add ISessionChangeset and new changesets observables to IChat and ISession.
  • Plumb empty/default changesets observables through Copilot chat sessions + agent host providers.
  • Update multiple Sessions-layer tests to include changesets in stubs/fixtures.
Show a summary per file
File Description
src/vs/sessions/services/sessions/common/session.ts Introduces ISessionChangeset and adds changesets to IChat/ISession.
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts Adds changesets to the Copilot sessions facade and adapters; currently scaffolded as empty.
src/vs/sessions/contrib/agentHost/browser/baseAgentHostSessionsProvider.ts Adds a changesets observable to agent-host session/chat models.
src/vs/sessions/services/sessions/test/browser/sessionsManagementService.test.ts Updates session/chat stubs to include changesets.
src/vs/sessions/contrib/terminal/test/browser/sessionsTerminalContribution.test.ts Updates test session fixtures to include changesets.
src/vs/sessions/contrib/sessions/test/browser/sessionsListModelService.test.ts Updates test session factory to include changesets.
src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts Updates test session factory to include changesets.
src/vs/sessions/contrib/github/test/browser/githubContribution.test.ts Updates ISession test implementation to include changesets.
src/vs/sessions/contrib/chat/test/browser/sessionsConfigurationService.test.ts Updates session fixtures to include changesets.
src/vs/sessions/contrib/agentHost/test/browser/agentHostSkillButtons.test.ts Updates active session test fixture to include changesets.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts:914

  • AgentSessionAdapter.update() updates _changes but does not update the newly introduced _changesets. If changesets are ever computed from the agent session, this adapter will stop reflecting updates after construction. Update update() to also set _changesets from _extractChangesets(session) (and consider updating it in the same transaction alongside _changes).
		this._changesets = observableValue<readonly ISessionChangeset[]>(this, this._extractChangesets(session));
		this.changesets = this._changesets;

		this._changes = observableValue<readonly ISessionFileChange[]>(this, this._extractChanges(session));
		this.changes = this._changes;
  • Files reviewed: 10/10 changed files
  • Comments generated: 3

Comment thread src/vs/sessions/services/sessions/common/session.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Screenshot Changes

Base: 44ffe22e Current: 71a3a8db

Changed (2)

agentSessionsViewer/WithMarkdownBadge/Dark
Before After
before after
agentSessionsViewer/WithMarkdownBadge/Light
Before After
before after

@lszomoru lszomoru merged commit ebfbb71 into main May 4, 2026
26 checks passed
@lszomoru lszomoru deleted the lszomoru/agents-changeset branch May 4, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants