Skip to content

sessions: hide "Enter to Apply" tooltip in workspace picker#313826

Merged
roblourens merged 1 commit into
mainfrom
roblou/agents/remove-enter-to-apply-tooltip
May 2, 2026
Merged

sessions: hide "Enter to Apply" tooltip in workspace picker#313826
roblourens merged 1 commit into
mainfrom
roblou/agents/remove-enter-to-apply-tooltip

Conversation

@roblourens
Copy link
Copy Markdown
Member

The shared ActionList renderer falls back to a "{keybinding} to Apply" tooltip on every item that has no explicit tooltip and no hover. That hint is appropriate for code-action menus but misleading in the session workspace picker, where every row was showing "Enter to Apply".

Changes

  • Add a new IActionListOptions.hideDefaultKeybindingTooltip flag. When set, ActionItemRenderer skips the default keybinding-based tooltip on items without an explicit tooltip/hover.
  • Opt the session workspace picker into the new flag in both presentations:
    • the flat picker (via _buildListOptions)
    • the tabbed picker (inline listOptions in _showTabbedPicker)

Notes for reviewers

Behavior of existing ActionList consumers (e.g. code action / lightbulb menus) is unchanged — they don't set the new flag.

(Written by Copilot)

The shared ActionList renderer falls back to a "{keybinding} to Apply"
tooltip when an item has no explicit tooltip/hover. That hint is misleading
in the session workspace picker, where items aren't code actions.

Add a new IActionListOptions.hideDefaultKeybindingTooltip flag and opt the
session workspace picker into it (for both the flat and tabbed
presentations).

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 2, 2026 00:10
@roblourens roblourens enabled auto-merge (squash) May 2, 2026 00:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines ActionList UX for the Agents window workspace picker by preventing the generic "{keybinding} to Apply" fallback tooltip from appearing on list rows where it’s misleading (e.g., “Enter to Apply” on every workspace row).

Changes:

  • Introduces IActionListOptions.hideDefaultKeybindingTooltip to suppress the default keybinding-based tooltip when no explicit tooltip/hover is provided.
  • Wires the workspace picker (flat + tabbed variants) to enable the new flag.
Show a summary per file
File Description
src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts Enables hideDefaultKeybindingTooltip for both flat and tabbed workspace picker list options.
src/vs/platform/actionWidget/browser/actionList.ts Adds the new options flag and plumbs it into ActionItemRenderer tooltip fallback behavior.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment thread src/vs/platform/actionWidget/browser/actionList.ts
Comment thread src/vs/platform/actionWidget/browser/actionList.ts
@roblourens roblourens merged commit 4ca77f1 into main May 2, 2026
43 of 45 checks passed
@roblourens roblourens deleted the roblou/agents/remove-enter-to-apply-tooltip branch May 2, 2026 01:16
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants