Skip to content

Change default for git.addAICoAuthor to off#313931

Merged
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/co-authoring-fixes
May 3, 2026
Merged

Change default for git.addAICoAuthor to off#313931
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/co-authoring-fixes

Conversation

@dmitrivMS
Copy link
Copy Markdown
Contributor

Also making sure change tracking is disabled when AI features are disabled.

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 3, 2026 06:59
@dmitrivMS dmitrivMS self-assigned this May 3, 2026
@dmitrivMS dmitrivMS enabled auto-merge (squash) May 3, 2026 06:59
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • extensions/git/package.json
  • extensions/git/src/repository.ts

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Screenshot Changes

Base: 6bdca786 Current: c6d6c063

Changed (28)

chat/aiCustomizations/aiCustomizationManagementEditor/McpDisabledByPolicy/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsDisabledByUser/Dark
Before After
before after
agentSessionsViewer/CompletedRead/Dark
Before After
before after
agentSessionsViewer/CompletedRead/Light
Before After
before after
agentSessionsViewer/CompletedUnread/Dark
Before After
before after
agentSessionsViewer/CompletedUnread/Light
Before After
before after
agentSessionsViewer/FailedWithDuration/Dark
Before After
before after
agentSessionsViewer/FailedWithDuration/Light
Before After
before after
agentSessionsViewer/FailedWithoutDuration/Dark
Before After
before after
agentSessionsViewer/FailedWithoutDuration/Light
Before After
before after
agentSessionsViewer/WithDiffChanges/Dark
Before After
before after
agentSessionsViewer/WithDiffChanges/Light
Before After
before after
agentSessionsViewer/WithFileChangesList/Dark
Before After
before after
agentSessionsViewer/WithFileChangesList/Light
Before After
before after
agentSessionsViewer/WithBadge/Dark
Before After
before after
agentSessionsViewer/WithBadge/Light
Before After
before after
agentSessionsViewer/WithMarkdownBadge/Dark
Before After
before after
agentSessionsViewer/WithMarkdownBadge/Light
Before After
before after
agentSessionsViewer/WithDescription/Dark
Before After
before after
agentSessionsViewer/WithDescription/Light
Before After
before after
agentSessionsViewer/WithBadgeAndDiff/Dark
Before After
before after
agentSessionsViewer/WithBadgeAndDiff/Light
Before After
before after
agentSessionsViewer/CloudProvider/Dark
Before After
before after
agentSessionsViewer/CloudProvider/Light
Before After
before after
agentSessionsViewer/BackgroundProvider/Dark
Before After
before after
agentSessionsViewer/BackgroundProvider/Light
Before After
before after
agentSessionsViewer/ClaudeProvider/Dark
Before After
before after
agentSessionsViewer/ClaudeProvider/Light
Before After
before after

blocks-ci screenshots changed

Replace the contents of test/componentFixtures/blocks-ci-screenshots.md with:

Updated blocks-ci-screenshots.md
<!-- auto-generated by CI — do not edit manually -->

#### editor/codeEditor/CodeEditor/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/cb32a3e854b5734fe5aaca2318f2e0a42ee821b05ea97883ea42c5ba95edb3c3)

#### editor/codeEditor/CodeEditor/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/42624fbba5e0db7f32c224b5eb9c5dd3b08245697ae2e7d2a88be0d7c287129b)

#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/28af1b719f3877d2f048fef10bb4534d5f638c1987bb0536331f4ab50ea0ea7a)

#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/c6c77ca2785665ae66c817cda21a8e5f5ea7d51e798c5b4e5aedcda9fd7323bd)

#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/2fbc12507b59ff950d9612d2df92e6b39d8bf0bf500478e42eca2ead4d1ae206)

#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/4632ab04d1fdd7db9ab0e00cce10aefb7a6344eb8869dfce740309a8801cab73)

@edenchazard
Copy link
Copy Markdown

Thanks for listening to the feedback!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes Git’s AI co-author behavior to be opt-in by default and ensures AI contribution tracking does not run when built-in AI features are disabled.

Changes:

  • Set the default for git.addAICoAuthor to "off" (schema + runtime default).
  • Prevent AI contribution tracking (AiContributionFeature) from activating when AI features are disabled/hidden.
  • Skip adding the AI co-author trailer when chat.disableAIFeatures is enabled.
Show a summary per file
File Description
src/vs/workbench/contrib/editTelemetry/browser/editTelemetryContribution.ts Gates AiContributionFeature activation behind the entitlement “hidden” state (covers chat.disableAIFeatures).
extensions/git/src/repository.ts Changes default addAICoAuthor fallback to "off" and avoids appending the trailer when AI features are disabled.
extensions/git/package.json Updates the configuration schema default for git.addAICoAuthor to "off".

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

@ecki
Copy link
Copy Markdown

ecki commented May 3, 2026

I would not mind it defaulting to on, if it actually works: not only for Copilot, reliable listing the actual model versions used, differentiating between agendic creation and input completion. Being able to reference a session log, helping with logging the evidence needed to get indemification protection. And commit message preview for human.

@dmitrivMS
Copy link
Copy Markdown
Contributor Author

I would not mind it defaulting to on, if it actually works: not only for Copilot, reliable listing the actual model versions used, differentiating between agendic creation and input completion. Being able to reference a session log, helping with logging the evidence needed to get indemification protection.

Agreed,. model attribution is really needed here, as well as making sure it doesn't catch non-AI changes.

@0xku
Copy link
Copy Markdown

0xku commented May 3, 2026

Thank you! Saw your post on hackernews as well. Appreciate the honesty here.

@dmitrivMS dmitrivMS merged commit d6c8e29 into main May 3, 2026
29 of 31 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/co-authoring-fixes branch May 3, 2026 07:58
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone May 3, 2026
@anka-213
Copy link
Copy Markdown

anka-213 commented May 3, 2026

Does this still add the attribution if copilot was active, but not used? Does it still do it silently?

@openscript
Copy link
Copy Markdown

Could we consider completely reverting this default back to off and instead notifying users about the new option so they can opt in? Given that the developer pushing the commits is ultimately responsible for the changes being introduced, it makes a lot of sense for this to be an explicit choice rather than an implicit default.

@LucasTavaresA
Copy link
Copy Markdown

no shot no one at microsoft told you this is a terrible idea XD

Comment thread extensions/git/src/repository.ts
@dmitrivMS
Copy link
Copy Markdown
Contributor Author

Could we consider completely reverting this default back to off and instead notifying users about the new option so they can opt in? Given that the developer pushing the commits is ultimately responsible for the changes being introduced, it makes a lot of sense for this to be an explicit choice rather than an implicit default.

That is exactly what this change is doing - default back to off.

@dmitrivMS
Copy link
Copy Markdown
Contributor Author

Does this still add the attribution if copilot was active, but not used? Does it still do or silently?

With this change, default behavior is there will be no attribution whether Copilot was used or not. So basically by default it works as if this feature does not exist at all.

When the setting is on, it will add attribution depending on the setting and there is more work to make sure it works correctly when the setting is 'all' and to make it more visible to the user.

@sodaxp
Copy link
Copy Markdown

sodaxp commented May 3, 2026

no shot no one at microsoft told you this is a terrible idea XD

Big Tech companies are so high on their supply that they'll push obviously awful changes just to please the investors. The worst part isn't that someone didn't think this was a terrible idea, the worst part is that the execs didn't listen to them.

@GeorgeSapkin
Copy link
Copy Markdown

Can we expect more silent and invasive changes in the near future? Were there any similar recent improvements forced by management? I think this was the final straw for most users. Good job, everybody involved. Zed it is.

@darshandzend
Copy link
Copy Markdown

I genuinely wonder. Why are you all using VSCode at all? Most modern editors have less than maybe 2 days of learning curve.

How hot does the water need to be before you decide to jump out?

@sodaxp
Copy link
Copy Markdown

sodaxp commented May 3, 2026

I genuinely wonder. Why are you all using VSCode at all? Most modern editors have less than maybe 2 days of learning curve.

You can't just say "most modern editors", and then continue on to not specify a single one lmao. If you want people to move off VSCode, you gotta give them a hint of what to move to.

@GeorgeSapkin
Copy link
Copy Markdown

If you want people to move off VSCode, you gotta give them a hint of what to move to.

Zed. Open-source, Rust, no Electron.

@sodaxp
Copy link
Copy Markdown

sodaxp commented May 3, 2026

Zed. Open-source, Rust, no Electron.

Their homepage advertises agentic development front and center (literally), I don't see why someone moving away from AI-focused tools would go to a different AI-focused tool.

@GeorgeSapkin
Copy link
Copy Markdown

Their homepage advertises agentic development front and center (literally), I don't see why someone moving away from AI-focused tools would go to a different AI-focused tool.

It's not AI-focused. In fact you can disable all "AI"-features if you want with a single switch.

@tanepiper
Copy link
Copy Markdown

The fact this feature flag is still there and after what happened with Recall - absolutely zero trust Microslop won't just sneakily re-enable this at some point.

What next? Automatic driving cars co-driven with Jesus taking the wheel?

@thehaiwave
Copy link
Copy Markdown

turn it back on, no balls

@Dennis4720
Copy link
Copy Markdown

I genuinely wonder. Why are you all using VSCode at all? Most modern editors have less than maybe 2 days of learning curve.

You can't just say "most modern editors", and then continue on to not specify a single one lmao. If you want people to move off VSCode, you gotta give them a hint of what to move to.

https://www.jetbrains.com/ides/

@omlt765
Copy link
Copy Markdown

omlt765 commented May 3, 2026

DID ANYONE THINK FOR ONE SECOND ABOUT THE LEGAL IMPLICATIONS OF THIS????

ARE YOU ALL OUT OF YOUR MINDS.

GET YOUR LAWYERS READY.

MY CODE IS MY PROPERTY AND FURTHERMORE THAT CHANGE IS PRETTY MUCH ILLEGAL IN THE EU.

@dmitrivMS
Copy link
Copy Markdown
Contributor Author

Do you folks want to move back to HN for discussion?

@MitchelMA
Copy link
Copy Markdown

This is all so abhorrently stupid, I hope everyone who worked on this pr seriously actually learns something from it

@digitalspaceport
Copy link
Copy Markdown

... learns something from it

If there is one thing we should count on, it's MS not learning.

@Voxybuns
Copy link
Copy Markdown

Voxybuns commented May 3, 2026

Do you folks want to move back to HN for discussion?

yeah, keep making fun of people rightfully upset about your reckless decision to forcefully mark their work as "co-authored" by slop, i'm sure that'll get people to trust your product 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.