Pass session capabilities to chat parser#314027
Merged
roblourens merged 4 commits intomainfrom May 6, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (13)
|
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/Default/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifacts/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodosAndFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodosAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/SimpleQA/Dark
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/SimpleQA/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/PendingToolApproval/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns outgoing chat request parsing with the remote session restore parsing path by ensuring contributed chat session capabilities are passed through as the parser’s attachment-capability context. This keeps slash prompt commands highlighted correctly for agent-host sessions immediately on send.
Changes:
- Pass session-contributed attachment capabilities into
ChatRequestParserwhen parsing outgoing requests. - Centralize capability selection logic in
ChatServicevia a small helper. - Add tests covering capability propagation for live send and remote-history restore parsing.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts |
Ensures attachmentCapabilities passed to the request parser prefer contributed session capabilities (matching restore path). |
src/vs/workbench/contrib/chat/test/common/chatService/chatService.test.ts |
Adds targeted tests asserting /skill ... is parsed as a ChatRequestSlashPromptPart for agent-host sessions. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@copilot review (Written by Copilot) |
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/b7cba409-bf92-438f-adda-5d09865bc766 Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>
Contributor
Addressed both issues raised in the review (commit
|
osortega
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing outgoing chat requests, use the contributed chat session capabilities as the attachment capability context, matching the remote session restore path. This keeps slash prompt commands highlighted correctly for agent-host sessions when messages are first sent, not only after reopening the session.
Adds targeted coverage for both live send and restored history parsing paths. (Written by Copilot)