Agents welcome: introduce isEmbeddedApp and parentAppName environment properties#314061
Merged
Agents welcome: introduce isEmbeddedApp and parentAppName environment properties#314061
Conversation
- Add isEmbeddedApp property to IEnvironmentService (optional, defaults false) - Add memoized parentAppNameShort and parentAppNameLong to IEnvironmentService - Compute parent app display names from isEmbeddedApp flag and product quality - Set isEmbeddedApp in NativeEnvironmentService from process.isEmbeddedApp - Thread isEmbeddedApp through INativeWindowConfiguration to renderer - Use environmentService.parentAppNameShort in welcome theme step button label Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sandy081
added
the
~release-cherry-pick
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces environment-service support for the Agents (embedded) app to identify the parent VS Code installation by name, and uses that in the Agents welcome walkthrough to correctly label the “Use My VS Code Theme” option.
Changes:
- Adds
isEmbeddedApp?: booleantoIEnvironmentService, threads it throughINativeWindowConfiguration, and wires it from main → renderer in native/Electron. - Adds memoized
parentAppNameShort/parentAppNameLonggetters onAbstractNativeEnvironmentServicebased on embedded-app status and product quality. - Updates the Agents welcome walkthrough to use
environmentService.parentAppNameShortinstead ofproductService.embedded?.nameShortfor the theme import label.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/environment/electron-browser/environmentService.ts | Passes isEmbeddedApp from window configuration into the native environment service. |
| src/vs/sessions/contrib/welcome/browser/sessionsWalkthrough.ts | Uses environmentService.parentAppNameShort to label the parent-theme import option correctly. |
| src/vs/platform/windows/electron-main/windowsMainService.ts | Adds isEmbeddedApp to the window configuration payload sent to the renderer. |
| src/vs/platform/window/common/window.ts | Extends INativeWindowConfiguration with optional isEmbeddedApp. |
| src/vs/platform/environment/node/environmentService.ts | Populates isEmbeddedApp in native/node environments from process.isEmbeddedApp. |
| src/vs/platform/environment/common/environment.ts | Extends IEnvironmentService with isEmbeddedApp and parentAppNameShort/Long properties. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 1
Contributor
|
This PR will be automatically cherry-picked to |
chrmarti
approved these changes
May 4, 2026
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces proper environment service properties for the embedded (Agents) app to identify its parent VS Code installation by name.
Changes
isEmbeddedApp?: booleantoIEnvironmentService— set fromprocess.isEmbeddedAppin native environments@memoizedparentAppNameShortandparentAppNameLonggetters toAbstractNativeEnvironmentService, computed fromisEmbeddedApp+ product quality:stable→ "VS Code" / "Visual Studio Code"insider→ "VS Code Insiders" / "Visual Studio Code Insiders"exploration→ "VS Code Exploration" / "Visual Studio Code Exploration"isEmbeddedAppthroughINativeWindowConfigurationso the renderer picks it upenvironmentService.parentAppNameShortin the welcome theme step to correctly label the "Use My VS Code Insiders Theme" button (previously showed "Use My Agents - Insiders Theme" because it usedproductService.embedded?.nameShort)Follow-up to