[cherry-pick] Fix Agents welcome theme import cleanup#314083
Merged
sandy081 merged 1 commit intorelease/1.119from May 4, 2026
Merged
[cherry-pick] Fix Agents welcome theme import cleanup#314083sandy081 merged 1 commit intorelease/1.119from
sandy081 merged 1 commit intorelease/1.119from
Conversation
vs-code-engineering
Bot
added
the
cherry-pick-artifact
lszomoru
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #314070 from
main.Fixes #314052
This fixes the Agents welcome theme picker so applying a parent VS Code custom theme is not undone by the preview cleanup when the walkthrough finishes.
Changes
IDisposableand usedispose()for preview cleanup.apply()is called, so later disposal does not uninstall the imported theme extension.