Only unmaximize auxiliary side bar on explicit user action#314111
Merged
Only unmaximize auxiliary side bar on explicit user action#314111
Conversation
… to an explicit user action
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an “explicit vs automatic” signal to editor-opening/visibility-change flows and uses it in the workbench layout to avoid unmaximizing the auxiliary side bar (e.g. maximized chat sessions view) when editors are opened programmatically (notably by chat editing).
Changes:
- Introduces
isExplicitmetadata in editor open options and propagates it through active/visible editor change events. - Updates chat editing to open edited files with
isExplicit: falsewhen usingaccessibility.openChatEditedFiles. - Updates layout logic to only unmaximize the auxiliary side bar on explicit user-initiated editor visibility changes.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/browser/workbenchTestServices.ts | Updates test editor service event typing to match the new visible-editors change event payload. |
| src/vs/workbench/services/editor/common/editorService.ts | Adds IVisibleEditorsChangeEvent and updates onDidVisibleEditorsChange to carry an explicitness signal. |
| src/vs/workbench/services/editor/browser/editorService.ts | Emits onDidVisibleEditorsChange with { isExplicit } derived from active editor change events. |
| src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingSession.ts | Marks automatically opened “chat edited files” editors as non-explicit. |
| src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingServiceImpl.ts | Marks chat-driven editor openings as non-explicit. |
| src/vs/workbench/common/editor.ts | Extends IActiveEditorChangeEvent with optional isExplicit. |
| src/vs/workbench/browser/parts/editor/editorGroupView.ts | Propagates options.isExplicit into the active editor change event. |
| src/vs/workbench/browser/layout.ts | Gates auxiliary bar unmaximize behavior on explicit user action. |
| src/vs/platform/editor/common/editor.ts | Adds isExplicit?: boolean to IEditorOptions to flow explicitness through editor opening APIs. |
Copilot's findings
- Files reviewed: 9/9 changed files
- Comments generated: 2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
amunger
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce a new flag to indicate whether editor visibility changes result from explicit user actions. Adjust layout behavior to only unmaximize the auxiliary side bar when the change is initiated by the user.fixes #303794