Skip to content

Disable flaky hover test#314129

Merged
pwang347 merged 2 commits intomainfrom
pawang/disableHoverTest
May 4, 2026
Merged

Disable flaky hover test#314129
pwang347 merged 2 commits intomainfrom
pawang/disableHoverTest

Conversation

@pwang347
Copy link
Copy Markdown
Member

@pwang347 pwang347 commented May 4, 2026

Related #314025

Copilot AI review requested due to automatic review settings May 4, 2026 15:39
@pwang347 pwang347 marked this pull request as ready for review May 4, 2026 15:39
@pwang347 pwang347 enabled auto-merge (squash) May 4, 2026 15:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR mitigates CI flakiness in the HoverService browser test suite by disabling a specific hover suppression/clearance behavior test that intermittently fails.

Changes:

  • Marked the “suppression clears after mouse re-enters and a new mouseleave dismisses normally” test as skipped.
Show a summary per file
File Description
src/vs/platform/hover/test/browser/hoverService.test.ts Skips a flaky HoverService layout/resize test to reduce intermittent failures.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

Comment thread src/vs/platform/hover/test/browser/hoverService.test.ts
Comment thread src/vs/platform/hover/test/browser/hoverService.test.ts
@pwang347 pwang347 merged commit 1bb9a48 into main May 4, 2026
26 checks passed
@pwang347 pwang347 deleted the pawang/disableHoverTest branch May 4, 2026 16:57
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants