[cherry-pick] Changes to remove '.' from allowRead and allowWrite#314259
Merged
dileepyavan merged 5 commits intomicrosoft:release/1.119from May 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Cherry-picks a fix into release/1.119 to tighten the terminal agent sandbox filesystem defaults by removing permissive '.'-based write allowances (and associated read re-allows), aligning sandbox behavior with the intended “workspace + sandbox temp dir” baseline.
Changes:
- Update agent sandbox filesystem configuration defaults for Linux/macOS
allowWritefrom['.']to[](and adjust Linux description). - Remove the implicit default write path (
~/.npm) fromTerminalSandboxService. - Update sandbox tests to match the new allowRead/allowWrite behavior.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts | Removes expectation that /home/user/.npm is re-allowed for reads by default. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts | Drops ~/.npm from default write paths; default writes now come from workspace folders + sandbox temp dir only. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts | Changes allowWrite defaults to [] and updates Linux setting description. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
dmitrivMS
previously approved these changes
May 4, 2026
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
vijayupadya
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #312717
Cherry-picks all commits from
DileepY/314056torelease/1.119.Cherry-picked commits:
Validation:
./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts --grep "^TerminalSandboxService - network domains should deny home reads while reallowing writable paths for reads$"→ 1 passing