[cherry-pick] Changes to include workspaceStorage directory for allowRead#314287
Merged
dileepyavan merged 1 commit intomicrosoft:release/1.119from May 5, 2026
Merged
Conversation
(cherry picked from commit b32a129)
Contributor
There was a problem hiding this comment.
Pull request overview
Cherry-picks a fix onto release/1.119 to ensure the terminal sandbox configuration continues to allow read access to VS Code’s per-workspace storage directory, even when user home reads are broadly denied (a common hardening setup).
Changes:
- Extend sandbox
filesystem.allowReadgeneration to always include the current workspace’sworkspaceStoragedirectory. - Add a regression test asserting
workspaceStorageHome/<workspaceId>is present inallowReadwhile home remains indenyRead.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts | Adds workspace-storage-derived path(s) into computed allowRead so workspace storage remains readable under home-deny configurations. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts | Adds coverage to verify workspace storage is re-allowed for reads when home is denied. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
dmitrivMS
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks
b32a129600dtorelease/1.119.Validation:
./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts --grep "should reallow reads from workspace storage|should deny home reads while reallowing writable paths for reads|should only add command-specific allowRead paths for the current command keywords"→ 4 passing