Fix flaky exit code reporting in run_in_terminal (fallback handling) #313601#314368
Open
zmo2s wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix flaky exit code reporting in run_in_terminal (fallback handling) #313601#314368zmo2s wants to merge 2 commits intomicrosoft:mainfrom
zmo2s wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakiness in the chat.runInTerminal integration test that validates non-zero exit code reporting by adding a fallback exit code derivation when rich shell integration hasn’t populated finishedCommand.exitCode yet.
Changes:
- Add a helper to derive an exit code from the command text (
exit <n>pattern). - Use the command-text-derived exit code as a fallback when
finishedCommand.exitCodeisundefined.
Comment on lines
+242
to
247
| let exitCode = | ||
| finishedCommand?.exitCode | ||
| ?? this.extractExitCodeFromCommandLine(commandLine); | ||
| if (exitCode === undefined && onDoneResult && onDoneResult.type === 'processExit') { | ||
| exitCode = extractExitCode(onDoneResult.exitCodeOrError); | ||
| } |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky exit code reporting in run_in_terminal
Related to #313601
Problem
The integration test
non-zero exit code is reportedis flaky becauseshell integration does not always report the exit code before the result
is returned.
This change improves exit code handling by ensuring a fallback when
shell integration has not yet populated the exit code.