fixes for agents window#314394
Merged
Merged
Conversation
Contributor
Screenshot ChangesBase: Changed (11)
|
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifacts/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodosAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/Full/Dark
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/SimpleQA/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/PendingToolApproval/Dark
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/MultiTurn/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors and rehomes “Agents window” related contributions, including the “Open in VS Code” titlebar widget/action for the Sessions (Agents) window, and updates user-facing labels from “Agents Application” to “Agents Window”.
Changes:
- Refactors “Open in VS Code” in the Sessions window into new web/desktop contribution entrypoints and moves the titlebar widget to
src/vs/sessions/browser/widget/. - Updates Agents-window-related UI strings (command title + tip tooltip) to “Open Agents Window”.
- Adjusts Agents window profile handling and updates related user data profile tests to match environment service API changes.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/electron-browser/actions/media/openInAgents.css | Removes an (apparently) obsolete CSS file for the workbench titlebar widget. |
| src/vs/workbench/contrib/chat/electron-browser/agentSessions/agentSessionsActions.ts | Renames the Agents window command title. |
| src/vs/workbench/contrib/chat/browser/chatTipCatalog.ts | Updates the Agents window tip tooltip text (but keeps “Agents Application” link text). |
| src/vs/sessions/test/browser/resolveRemoteAuthority.test.ts | Adjusts import paths for moved/relocated utilities. |
| src/vs/sessions/sessions.web.main.ts | Removes old Open-in-VS-Code contribution import; adds new web contribution entrypoint. |
| src/vs/sessions/sessions.desktop.main.ts | Reorganizes sessions desktop contributions; adds new desktop contribution entrypoint. |
| src/vs/sessions/electron-browser/sessions.desktop.contribution.ts | New: registers desktop “Open in VS Code” action + widget contribution. |
| src/vs/sessions/electron-browser/actions/vscodeActions.ts | New: desktop implementation of “Open in VS Code” using INativeHostService.openWindow. |
| src/vs/sessions/contrib/chat/electron-browser/openInVSCode.contribution.ts | Deletes the previous desktop contribution that registered Open-in-VS-Code + debug action. |
| src/vs/sessions/contrib/chat/electron-browser/chat.contribution.ts | New: registers DebugAgentHostInDevToolsAction after the split. |
| src/vs/sessions/contrib/chat/browser/openInVSCodeWidget.ts | Deletes the old widget implementation location. |
| src/vs/sessions/contrib/chat/browser/chat.contribution.ts | Stops importing the old Open-in-VS-Code widget registration. |
| src/vs/sessions/browser/widget/openInVSCodeWidget.ts | New: shared Open-in-VS-Code titlebar widget implementation. |
| src/vs/sessions/browser/sessions.web.contribution.ts | New: registers web “Open in VS Code” action + widget contribution. |
| src/vs/sessions/browser/openInVSCodeUtils.ts | Fixes relative import paths after refactor. |
| src/vs/sessions/browser/media/vscode-icon.svg | New: bundled fallback VS Code icon for dev builds. |
| src/vs/sessions/browser/media/openInVSCode.css | Fixes relative path to code-icon.svg. |
| src/vs/sessions/browser/actions/vscodeActions.ts | Refactors web implementation into exported classes (registration moved to new contribution). |
| src/vs/platform/userDataProfile/test/electron-main/userDataProfileMainService.test.ts | Updates environment service construction to new paths API. |
| src/vs/platform/userDataProfile/test/common/userDataProfileService.test.ts | Updates environment service construction to new paths API. |
| src/vs/platform/userDataProfile/common/userDataProfile.ts | Refactors Agents window profile defaults + workspace→profile selection behavior. |
Copilot's findings
- Files reviewed: 20/21 changed files
- Comments generated: 6
| localize( | ||
| 'tip.openAgentsWindow', | ||
| "Try the [Agents Application](command:{0} \"Open Agents Application\") to run multiple agents simultaneously and manage your coding sessions.", | ||
| "Try the [Agents Application](command:{0} \"Open Agents Window\") to run multiple agents simultaneously and manage your coding sessions.", |
| import './contrib/remoteAgentHost/browser/tunnelAgentHost.contribution.js'; | ||
|
|
||
| // Chat | ||
| import './contrib/chat/electron-browser/chat.contribution.js'; |
| this.uriIdentityService.extUri.joinPath(this.profilesHome, ...(id === AGENTS_WINDOW_PROFILE_ID ? [SYSTEM_PROFILES_HOME, id] : [id])), | ||
| this.profilesCacheHome, | ||
| id === AGENTS_WINDOW_PROFILE_ID ? AGENTS_WINDOW_PROFILE_OPTIONS : options, | ||
| id === AGENTS_WINDOW_PROFILE_ID ? {} : options, |
Comment on lines
23
to
+33
| class TestEnvironmentService extends AbstractNativeEnvironmentService { | ||
| constructor(private readonly _appSettingsHome: URI) { | ||
| super(Object.create(null), Object.create(null), { _serviceBrand: undefined, ...product }); | ||
| const userDataDir = _appSettingsHome.fsPath.replace(/\/User$/, ''); | ||
| const paths: INativeEnvironmentPaths = { | ||
| userDataDir, | ||
| homeDir: userDataDir, | ||
| tmpDir: userDataDir, | ||
| parentAppUserDataDir: undefined, | ||
| parentAppUserHomeDir: undefined | ||
| }; | ||
| super(Object.create(null), paths, { _serviceBrand: undefined, ...product }); |
Comment on lines
22
to
33
| class TestEnvironmentService extends AbstractNativeEnvironmentService { | ||
| constructor(private readonly _appSettingsHome: URI) { | ||
| super(Object.create(null), Object.create(null), { _serviceBrand: undefined, ...product }); | ||
| const userDataDir = _appSettingsHome.fsPath.replace(/\/User$/, ''); | ||
| const paths: INativeEnvironmentPaths = { | ||
| userDataDir, | ||
| homeDir: userDataDir, | ||
| tmpDir: userDataDir, | ||
| parentAppUserDataDir: undefined, | ||
| parentAppUserHomeDir: undefined | ||
| }; | ||
| super(Object.create(null), paths, { _serviceBrand: undefined, ...product }); | ||
| } |
Comment on lines
+30
to
+38
| export class OpenInVSCodeAction extends Action2 { | ||
| static readonly ID = 'agents.openInVSCode'; | ||
|
|
||
| constructor() { | ||
| super({ | ||
| id: OpenInVSCodeAction.ID, | ||
| title: localize2('openInVSCode', 'Open in VS Code'), | ||
| icon: Codicon.vscodeInsiders, | ||
| precondition: ContextKeyExpr.and(IsAuxiliaryWindowContext.toNegated(), SessionsWelcomeVisibleContext.toNegated()), |
aiday-mar
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.