Skip to content

Fix UBB detection#314584

Merged
pwang347 merged 2 commits into
mainfrom
pawang/fixUbbDetection
May 6, 2026
Merged

Fix UBB detection#314584
pwang347 merged 2 commits into
mainfrom
pawang/fixUbbDetection

Conversation

@pwang347
Copy link
Copy Markdown
Member

@pwang347 pwang347 commented May 5, 2026

Fixes #314586

Copilot AI review requested due to automatic review settings May 5, 2026 23:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Screenshot Changes

Base: f20ea1ce Current: 3eb364e5

Changed (10)

chat/input/chatInput/WithArtifacts/Dark
Before After
before after
chat/input/chatInput/WithArtifacts/Light
Before After
before after
chat/input/chatInput/WithFileChanges/Dark
Before After
before after
chat/input/chatInput/WithFileChanges/Light
Before After
before after
chat/input/chatInput/WithTodos/Dark
Before After
before after
chat/input/chatInput/WithTodos/Light
Before After
before after
chat/input/chatInput/WithTodosAndFileChanges/Dark
Before After
before after
chat/input/chatInput/WithArtifactsAndFileChanges/Dark
Before After
before after
chat/input/chatInput/WithArtifactsAndFileChanges/Light
Before After
before after
chat/widget/chatWidget/MultiTurn/Light
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the chat entitlement/quota parsing to correctly detect usage-based billing (UBB/TBB) from the entitlement payload so the workbench can present the right quota UI/telemetry.

Changes:

  • Read usageBasedBilling from entitlementsData.token_based_billing when building quota snapshots.
  • Extend the IEntitlementsData wire-type to include the token_based_billing field.
Show a summary per file
File Description
src/vs/workbench/services/chat/common/chatEntitlementService.ts Adjusts quota snapshot mapping to use top-level entitlements UBB flag.
src/vs/base/common/defaultAccount.ts Adds token_based_billing to the entitlements payload type.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment thread src/vs/workbench/services/chat/common/chatEntitlementService.ts Outdated
@pwang347 pwang347 marked this pull request as ready for review May 5, 2026 23:47
@pwang347 pwang347 enabled auto-merge (squash) May 5, 2026 23:47
@pwang347 pwang347 disabled auto-merge May 6, 2026 00:01
@pwang347 pwang347 enabled auto-merge (squash) May 6, 2026 00:10
@pwang347 pwang347 merged commit c7bc16d into main May 6, 2026
26 checks passed
@pwang347 pwang347 deleted the pawang/fixUbbDetection branch May 6, 2026 00:41
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pro UBB user not being detected properly

3 participants