Git - guard against undefined paths in parseGitChangesRaw (#287615)

[yogeshwaran-c]

@
Fixes #287615

Root cause

parseGitChangesRaw in extensions/git/src/git.ts parses the null-delimited output of git diff --raw --numstat -z. The parser advances through the segments array using a manual index++ counter and reads file paths via segments[index++] in two places:

1. The colon-prefixed --raw branch: the file path that immediately follows the metadata segment.
2. The --numstat rename branch: the new path that follows the empty filename and the skipped old path.

Neither read was guarded for the case where index runs past the end of segments (or yields an empty/undefined value). When that happens, the resulting filePath is undefined, and the subsequent Uri.file(...) call throws:

The "path" argument must be of type string. Received undefined

This bubbles up through GitHistoryProvider.provideHistoryItemChanges and is logged by extHostSCM.ts as ExtHostSCM#$provideHistoryItemChanges The "path" argument must be of type string. Received undefined, leaving the multi-file diff editor with no listed files.

Fix

Add a defensive if (!filePath) break; / if (!renamePath) break; guard in both branches, mirroring the existing guard already present for the rename newPath segment a few lines below. If the segment stream is unexpectedly truncated, parsing stops cleanly instead of crashing the provider call.

Narrow change: 6 added lines in one file, no behavior change for well-formed input.

Test plan

• Build passes locally
• Open commit history for a commit with many changes (including renames) — no path must be of type string error in Extension Host log; changed files render in the multi-file diff editor.
  @

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

• extensions/git/src/git.ts

[Copilot]

Pull request overview

This PR hardens the Git extension’s parseGitChangesRaw parser (used for git diff --raw --numstat -z) to avoid throwing when the null-delimited segment stream is unexpectedly truncated, which was surfacing as Uri.file(...) receiving undefined and breaking commit history/multi-file diff rendering.

Changes:

• Add defensive guards to stop parsing when a --raw file path segment is missing.
• Add defensive guards to stop parsing when a --numstat rename “new path” segment is missing.