chore: track running agents app via marker file#314730
Merged
deepak1556 merged 2 commits intomainfrom May 6, 2026
Merged
Conversation
sandy081
previously approved these changes
May 6, 2026
Contributor
|
Base:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Tracks when the embedded Agents sub-application is/was running by writing a marker file into the host VS Code’s user-data area, so a future build (after removing sub-app support) can detect this state and restore or migrate the Agents window appropriately.
Changes:
- Hook marker tracking into Electron main startup when running as the embedded app.
- Add
AgentsLastRunningTrackerthat writesagentsLastRunning.jsonand refreshes it on cross-app IPC connect/disconnect.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/code/electron-main/app.ts | Instantiates the marker writer when running as the embedded Agents app and the host user-data path is available. |
| src/vs/code/electron-main/agentsLastRunningTracker.ts | New tracker that writes/updates the host-side marker file with basic liveness metadata. |
sandy081
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we deploy #314409 this change will allow us to restore agents window with a deprecation message.