Fix memory leaks in AgentFeedbackInputWidget

[benibenj]

Copilot Generated Description: Refactor the AgentFeedbackInputWidget to properly register disposables, preventing memory leaks.

fixes #314629

[github-actions]

Screenshot Changes

Base: dc1de9b2 Current: eaff28fe

Changed (1)

chat/widget/chatWidget/PendingToolApproval/Light

Before	After

[Copilot]

Pull request overview

This PR fixes a disposal-related memory leak in the Agents window’s agent feedback input overlay by making AgentFeedbackInputWidget a proper Disposable and registering all of its owned resources (emitters, actions, action bar, and the ModifierKeyEmitter subscription) with _register(). This directly addresses the reported runtime error where ActionBar.push() was invoked after the ActionBar had already been disposed (triggered via a lingering modifier-key listener).

Changes:

• Convert AgentFeedbackInputWidget to extend Disposable and call super() in the constructor.
• Register Emitters, Actions, ActionBar, and the ModifierKeyEmitter event subscription via _register() to ensure teardown happens reliably.
• Remove the manual dispose() implementation in favor of Disposable’s tracked disposal.

Show a summary per file

File	Description
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts	Ensures the overlay input widget correctly owns and disposes its emitters/actions/action bar and modifier-key listener to prevent post-dispose updates and leaks.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0