chat: lowercase 'artifacts' in artifacts widget header#315150
Open
mokashang wants to merge 1 commit into
Open
Conversation
Aligns the artifacts count label casing with the adjacent "file change" label, which is rendered lowercase. Maintainer indicated this preference in microsoft#309415. Closes microsoft#309415
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the chat artifacts widget header text in the VS Code workbench chat UI to use lowercase “artifact(s)”, aligning its casing with the neighboring lowercase “file change” label.
Changes:
- Lowercase the singular label from “1 Artifact” to “1 artifact”.
- Lowercase the plural label from “{0} Artifacts” to “{0} artifacts” while keeping localization keys unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowercases the artifacts count label in the chat artifacts widget header so it visually aligns with the adjacent lowercase "file change" label.
Per @roblourens in #309415: "I would probably go lowercase on artifacts".
Change
src/vs/workbench/contrib/chat/browser/widget/chatArtifactsWidget.tsThe
localizekeys are unchanged; only the source English strings change.How to test
N artifacts(or1 artifact) instead ofN Artifacts.Closes #309415