Agents - set the title/aria label for the button when the custom label changes#315210
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workbench button bar so that when a button’s custom/observable label changes (used by Agents UI), the button’s tooltip/title and aria-label are refreshed to match the new label (including keybinding text).
Changes:
- Add
setTitle(...)andsetAriaLabel(...)to theIButtoninterface and forward them through composite button implementations. - Update
WorkbenchButtonBarto recompute a plaintext label (stripping codicons) and apply it as the button title and aria label when the custom label changes. - Introduce helper imports (
renderAsPlaintext,stripIcons) to generate accessible label text.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/actions/browser/buttonbar.ts | Updates label-change handling to also update tooltip/title and aria-label based on the current label text. |
| src/vs/base/browser/ui/button/button.ts | Extends the IButton API with setTitle/setAriaLabel and implements/forwards them in button classes. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
benibenj
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.