Enable agents window in stable#315245
Merged
Merged
Conversation
- Remove quality !== 'stable' guards from --agents CLI flag handling and last-running marker restore in app.ts - Remove quality !== 'stable' guard from launchMainService when re-launching with --agents flag - Remove quality !== 'stable' guard from OPEN_AGENTS_WINDOW_PRECONDITION context key expression - Enable 'Try out the new Agents' banner in stable (canShowAgentsBanner no longer checks quality) - Remove the 'tip.openAgentsWindow' chat tip shown above the chat input Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @deepak1556Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the Agents window experience in Stable builds by removing product-quality gating across window launch/restore paths, command preconditions, and related promotional UI.
Changes:
- Removes
quality !== 'stable'guards for launching/restoring the Agents window (--agentsflag and last-running marker restore). - Enables the “Open Agents Window” action precondition in Stable by dropping the
ProductQualityContextcheck. - Simplifies Agents banner gating and removes the “open agents window” chat tip entry.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts | Updates Agents banner visibility check to match new canShowAgentsBanner signature. |
| src/vs/workbench/contrib/welcomeAgentSessions/browser/agentSessionsWelcome.ts | Updates Agents banner visibility check to match new canShowAgentsBanner signature. |
| src/vs/workbench/contrib/chat/common/constants.ts | Removes Stable-quality gate from OPEN_AGENTS_WINDOW_PRECONDITION. |
| src/vs/workbench/contrib/chat/browser/chatTipCatalog.ts | Removes the tip.openAgentsWindow tip and associated imports. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsBanner.ts | Removes product-quality gating from banner eligibility and drops IProductService dependency. |
| src/vs/platform/launch/electron-main/launchMainService.ts | Allows --agents relaunch in Stable; removes now-unused IProductService injection. |
| src/vs/code/electron-main/app.ts | Allows --agents handling and last-running marker restore in Stable. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 1
Comment on lines
35
to
+39
| * The banner requires the open agents window command | ||
| * to be registered (desktop builds only) and is limited to Insiders quality. | ||
| * It is also hidden when AI features are disabled. | ||
| */ | ||
| export function canShowAgentsBanner(productService: IProductService, chatEntitlementService: IChatEntitlementService): boolean { | ||
| export function canShowAgentsBanner(chatEntitlementService: IChatEntitlementService): boolean { |
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/OrangeElicitationInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/RedElicitationInContext/Dark
| Before | After |
|---|---|
 |
 |
chat/chatToolRiskBadge/RedElicitationInContext/Light
| Before | After |
|---|---|
 |
 |
lszomoru
approved these changes
May 8, 2026
lszomoru
pushed a commit
that referenced
this pull request
May 8, 2026
- Remove quality !== 'stable' guards from --agents CLI flag handling and last-running marker restore in app.ts - Remove quality !== 'stable' guard from launchMainService when re-launching with --agents flag - Remove quality !== 'stable' guard from OPEN_AGENTS_WINDOW_PRECONDITION context key expression - Enable 'Try out the new Agents' banner in stable (canShowAgentsBanner no longer checks quality) - Remove the 'tip.openAgentsWindow' chat tip shown above the chat input Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hi, I don't think the Agents Window is ready for stable. It still has a lot of development work remaining. In agents window: In vscode window: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all
quality !== 'stable'guards that were blocking the agents window from being accessible in stable builds.Changes
app.ts— Remove quality check from--agentsCLI flag and fromtryConsumeAgentsLastRunningMarker(agents window now restores on startup in stable too)launchMainService.ts— Remove quality check when re-launching with--agentsflag; remove now-unusedIProductServicedependencyconstants.ts— RemoveProductQualityContext.notEqualsTo('stable')fromOPEN_AGENTS_WINDOW_PRECONDITION, enabling the "Open Agents Window" action in stableagentSessionsBanner.ts— Remove quality check fromcanShowAgentsBannerso the "Try out the new Agents" banner shows in stable (for users with Copilot access); remove now-unusedproductServiceparameterchatTipCatalog.ts— Remove thetip.openAgentsWindowchat tip shown above the chat input — already enough promotion via the banner and actionsNot changed
agentsAppMergedBanner.contribution.ts— Kept gated to non-stable (migration notice for users of the old standalone Agents app, which never existed in stable)agentSessionsBanner.ts(canShowAgentsBanner) — The banner itself still respects AI entitlement (sentiment.hidden,sentiment.disabled), just no longer requires non-stableagentSessionsExperiments.contribution.ts— "Agent Quick Input" toggle kept as Insiders-only experimental feature