Log ssh send failure

[roblourens]

No description provided.

[Copilot]

Pull request overview

This PR adds logging to the SSH relay protocol transport so that failures to send messages over the SSH relay are surfaced via the VS Code logging infrastructure, and wires up dependency injection to provide an ILogService to the transport.

Changes:

• Inject ILogService into SSHRelayTransport and log relay close + relay send failures.
• Switch SSH relay transport construction to IInstantiationService.createInstance(...) to satisfy the new service dependency.
• Update SSH relay transport unit tests to pass a NullLogService when constructing the transport directly.

Show a summary per file

File	Description
src/vs/platform/agentHost/test/electron-browser/sshRelayTransport.test.ts	Updates tests to pass a NullLogService due to the new ILogService dependency.
src/vs/platform/agentHost/electron-browser/sshRemoteAgentHostServiceImpl.ts	Uses DI (createInstance) to construct SSHRelayTransport with injected services.
src/vs/platform/agentHost/electron-browser/sshRelayTransport.ts	Adds ILogService injection and logs relay close + relaySend failures.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/platform/agentHost/electron-browser/sshRelayTransport.ts:67

• relaySend failures are commented as a likely/expected consequence of a closed connection in the similar TunnelRelayTransport implementation, but here they are logged at error level. This risks log spam during normal teardown or transient disconnects. Consider either (a) logging at trace/warn with this._connectionId included, (b) suppressing known/expected errors (e.g. disposed/canceled), or (c) rate-limiting to once per connection.

	send(message: ProtocolMessage | AhpServerNotification | JsonRpcNotification | JsonRpcResponse | JsonRpcRequest): void {
		const text = JSON.stringify(message);
		this._ahpLogger?.log(message, 'c2s', getAhpLogByteLength(text));
		this._sshService.relaySend(this._connectionId, text).catch((err) => {
			this._logService.error('[SSHRelayTransport] relaySend failed', err);
		});

• Files reviewed: 3/3 changed files
• Comments generated: 1

[eremognosis]

Looks Good
It logs actually well
No issues found

[github-actions]

Screenshot Changes

Base: 123d29a0 Current: 40251f85

Changed (6)

agentSessionsViewer/FailedWithoutDuration/Dark

Before	After

agentSessionsViewer/FailedWithoutDuration/Light

Before	After

agentSessionsViewer/WithBadgeAndDiff/Dark

Before	After

agentSessionsViewer/WithBadgeAndDiff/Light

Before	After

agentSessionsViewer/ClaudeProvider/Dark

Before	After

agentSessionsViewer/ClaudeProvider/Light

Before	After