github-auth: revert sessions-specific auth branding#315792
Merged
Merged
Conversation
Revert PR #298277 changes since agents is no longer a separate app. Removes sessions icon swap from the auth redirect page, the agentSessionsWorkspace API usage, and the sessions-icon.svg asset. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sandy081
added
the
~release-cherry-pick
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the sessions-specific GitHub auth redirect branding introduced in #298277, aligning the GitHub Authentication extension with the updated product direction that “agents” is no longer a separate app.
Changes:
- Removes the
app_is_sessionsquery parameter plumbing and the sessions icon swap on the auth redirect page. - Drops
agentSessionsWorkspaceproposed API usage/enablement from the extension (package + tsconfig + code). - Deletes the now-unused
sessions-icon.svgasset from the extension media.
Show a summary per file
| File | Description |
|---|---|
| extensions/github-authentication/tsconfig.json | Removes the agentSessionsWorkspace proposed d.ts reference from the extension compile inputs. |
| extensions/github-authentication/src/node/authServer.ts | Stops appending app_is_sessions to redirect URLs and removes workspace.isAgentSessionsWorkspace usage. |
| extensions/github-authentication/package.json | Removes agentSessionsWorkspace from enabledApiProposals. |
| extensions/github-authentication/media/sessions-icon.svg | Deletes the sessions-specific icon asset. |
| extensions/github-authentication/media/index.html | Removes app_is_sessions handling and sessions icon switching logic. |
Copilot's findings
- Files reviewed: 4/5 changed files
- Comments generated: 2
TylerLeonhardt
approved these changes
May 11, 2026
Contributor
|
This PR will be automatically cherry-picked to |
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR #298277 since agents is no longer a separate app.
Changes
app_is_sessionsquery param handling from the auth redirect page (index.html)sessions-icon.svgassetagentSessionsWorkspacefromenabledApiProposalsinpackage.jsonworkspace.isAgentSessionsWorkspaceusage fromauthServer.tstsconfig.json