Skip to content

Remove github.copilot.chat.tools.memory.enabled setting#315879

Merged
bhavyaus merged 1 commit into
mainfrom
dev/bhavyau/remove-memory-tool-setting
May 11, 2026
Merged

Remove github.copilot.chat.tools.memory.enabled setting#315879
bhavyaus merged 1 commit into
mainfrom
dev/bhavyau/remove-memory-tool-setting

Conversation

@bhavyaus
Copy link
Copy Markdown
Collaborator

Memory tool is now always enabled. Removes the preview-gated setting and the now-unused gating code.

Memory tool is now always enabled. Removes the preview gate, the config
key, the now-unused DI params on MemoryTool/MemoryContextPrompt/
MemoryInstructionsPrompt, and isAnthropicMemoryToolEnabled (replaced by
modelSupportsMemory at the BYOK call site).
Copilot AI review requested due to automatic review settings May 11, 2026 21:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the preview-gated github.copilot.chat.tools.memory.enabled setting and associated code paths so the memory tool is treated as always enabled (while still respecting model capability checks where applicable).

Changes:

  • Removed the chat.tools.memory.enabled configuration key and its package.json / NLS contributions.
  • Deleted gating logic around memory prompt rendering and memory cleanup startup.
  • Simplified Anthropic BYOK memory-tool enablement to be based solely on model support.
Show a summary per file
File Description
extensions/copilot/src/platform/networking/common/anthropic.ts Removes isAnthropicMemoryToolEnabled helper now that the setting gate is gone.
extensions/copilot/src/platform/configuration/common/configurationService.ts Drops ConfigKey.MemoryToolEnabled definition.
extensions/copilot/src/extension/tools/node/memoryTool.tsx Always starts the memory cleanup service; removes config/experimentation injections.
extensions/copilot/src/extension/tools/node/memoryContextPrompt.tsx Always renders memory context/instructions (no setting gate).
extensions/copilot/src/extension/byok/vscode-node/anthropicProvider.ts Uses modelSupportsMemory directly to decide native Anthropic memory tool usage.
extensions/copilot/package.nls.json Removes the localized description string for the deleted setting.
extensions/copilot/package.json Removes the setting definition and all when clauses tied to it (tool + command palette gating).

Copilot's findings

  • Files reviewed: 7/7 changed files
  • Comments generated: 0

@bhavyaus bhavyaus enabled auto-merge (squash) May 11, 2026 21:34
@bhavyaus bhavyaus merged commit cf21e20 into main May 11, 2026
29 checks passed
@bhavyaus bhavyaus deleted the dev/bhavyau/remove-memory-tool-setting branch May 11, 2026 22:00
@vs-code-engineering vs-code-engineering Bot added this to the 1.121.0 milestone May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants