[cherry-pick] terminal: fix Linux sandbox wrapper env assignment#315924
Open
vs-code-engineering[bot] wants to merge 1 commit into
Open
[cherry-pick] terminal: fix Linux sandbox wrapper env assignment#315924vs-code-engineering[bot] wants to merge 1 commit into
vs-code-engineering[bot] wants to merge 1 commit into
Conversation
vs-code-engineering
Bot
added
the
cherry-pick-artifact
roblourens
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #315828 from
release/1.120.Fixes #314695.
What changed
ELECTRON_RUN_AS_NODE=1onto the sandbox runtime invocation itself before the Linux temp-dir wrapper prependscd <tmp>;cd ...; ELECTRON_RUN_AS_NODE=1 PATH=...wrapper shapeWhy
On Linux, the wrapper could be emitted as
ELECTRON_RUN_AS_NODE=1 cd <tmp>; ..., which only applied the environment variable tocd. That causedcodeto opencli.jsfor editing instead of running the sandbox runtime with--settingsand-c.